Buffer Issue

[kornom]

If you want to receive support we need this info to help you properly.
» Find Revision
L2J Revision Number:LAST
L2JDP Revision Number:LAST

Hello friends, lately I upgraded to BETA version and I realized that My edited rin4as buffer wont work any more since jython module was removed,

from com.l2jserver.gameserver.model.quest.jython import QuestJython as JQuest wont work

Is it possible to remake or perhaps do anything for my old buffer o work again on the beta?

YANBuffer is not working as NPC , I pmed FBIAgent about it and hope to hear soon from him.

But I do prefer my old buffer...

[Zoey76]

Try from com.l2jserver.gameserver.model.quest import Quest as JQuest

[kornom]

Now it loads it but I get:

Code: Select all

main$Quest$142: nullUnclosed connection! Trace: sun.reflect.NativeMethodAccessorImpl.invoke0(NativeMethod)java.lang.RuntimeException        at com.l2jserver.L2DatabaseFactory.getConnection(L2DatabaseFactory.java:180)        at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)        at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)        at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)        at java.lang.reflect.Method.invoke(Unknown Source)        at org.python.core.PyReflectedFunction.__call__(Unknown Source)        at org.python.core.PyMethod.__call__(Unknown Source)        at org.python.core.PyObject.__call__(Unknown Source)        at org.python.core.PyInstance.invoke(Unknown Source)        at org.python.pycode.serializable._pyx1387420077722.generateScheme$2(custom/555_NPCBUFFER/__init__.py:129)        at org.python.pycode.serializable._pyx1387420077722.call_function(custom/555_NPCBUFFER/__init__.py)        at org.python.core.PyTableCode.call(Unknown Source)        at org.python.core.PyTableCode.call(Unknown Source)        at org.python.core.PyFunction.__call__(Unknown Source)        at org.python.pycode.serializable._pyx1387420077722.rebuildMainHtml$1(custom/555_NPCBUFFER/__init__.py:117)        at org.python.pycode.serializable._pyx1387420077722.call_function(custom/555_NPCBUFFER/__init__.py)        at org.python.core.PyTableCode.call(Unknown Source)        at org.python.core.PyTableCode.call(Unknown Source)        at org.python.core.PyFunction.__call__(Unknown Source)        at org.python.pycode.serializable._pyx1387420077722.onAdvEvent$14(custom/555_NPCBUFFER/__init__.py:686)        at org.python.pycode.serializable._pyx1387420077722.call_function(custom/555_NPCBUFFER/__init__.py)        at org.python.core.PyTableCode.call(Unknown Source)        at org.python.core.PyTableCode.call(Unknown Source)        at org.python.core.PyTableCode.call(Unknown Source)        at org.python.core.PyFunction.__call__(Unknown Source)        at org.python.core.PyMethod.__call__(Unknown Source)        at org.python.core.PyObject.__call__(Unknown Source)        at org.python.core.PyObject._jcallexc(Unknown Source)        at org.python.core.PyObject._jcall(Unknown Source)        at org.python.proxies.main$Quest$142.onAdvEvent(Unknown Source)        at com.l2jserver.gameserver.model.quest.Quest.notifyEvent(Quest.java:558)        at com.l2jserver.gameserver.model.actor.instance.L2PcInstance.processQuestEvent(L2PcInstance.java:1688)        at handlers.bypasshandlers.QuestLink.useBypass(QuestLink.java:72)        at com.l2jserver.gameserver.network.clientpackets.RequestBypassToServer.runImpl(RequestBypassToServer.java:340)        at com.l2jserver.gameserver.network.clientpackets.L2GameClientPacket.run(L2GameClientPacket.java:70)        at com.l2jserver.gameserver.network.L2GameClient.run(L2GameClient.java:1133)        at java.util.concurrent.ThreadPoolExecutor.runWorker(Unknown Source)        at java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source)        at java.lang.Thread.run(Unknown Source)

[Zoey76]

And I cannot help you without the script.

[kornom]

And I cannot help you without the script.

Zoey, you are my last hope!
There you go: http://pastebin.com/jxT4LsCz



Those are the errors I get in game.

[Zoey76]

You are missing a database update (table buffer_scheme_list).

[kornom]

Zoey looks like I do have it, It is probably structured wrong...



I assume PlayerID is wrong, since I get an error ingame

[kornom]

Ok Zoey your right, I resolved the DB table issue, now I can see the main screen at the buffer, and everything!

last problem, when I try to get buff I get this>

Code: Select all

C:\Users\Exact\Desktop\10072-6311\game\data\scripts\custom\555_NPCBUFFER\__init__.pyTraceback (innermost last):  File "custom/555_NPCBUFFER/__init__.py", line 967, in onAdvEventAttributeError: getEffects         at org.python.core.Py.AttributeError(Unknown Source)        at org.python.core.PyInstance.invoke(Unknown Source)        at org.python.pycode.serializable._pyx1387432255530.onAdvEvent$14(custom/555_NPCBUFFER/__init__.py:967)        at org.python.pycode.serializable._pyx1387432255530.call_function(custom/555_NPCBUFFER/__init__.py)        at org.python.core.PyTableCode.call(Unknown Source)        at org.python.core.PyTableCode.call(Unknown Source)        at org.python.core.PyTableCode.call(Unknown Source)        at org.python.core.PyFunction.__call__(Unknown Source)        at org.python.core.PyMethod.__call__(Unknown Source)        at org.python.core.PyObject.__call__(Unknown Source)        at org.python.core.PyObject._jcallexc(Unknown Source)        at org.python.core.PyObject._jcall(Unknown Source)        at org.python.proxies.main$Quest$144.onAdvEvent(Unknown Source)        at com.l2jserver.gameserver.model.quest.Quest.notifyEvent(Quest.java:558)        at com.l2jserver.gameserver.model.actor.instance.L2PcInstance.processQuestEvent(L2PcInstance.java:1688)        at handlers.bypasshandlers.QuestLink.useBypass(QuestLink.java:72)        at com.l2jserver.gameserver.network.clientpackets.RequestBypassToServer.runImpl(RequestBypassToServer.java:340)        at com.l2jserver.gameserver.network.clientpackets.L2GameClientPacket.run(L2GameClientPacket.java:70)        at com.l2jserver.gameserver.network.L2GameClient.run(L2GameClient.java:1133)        at java.util.concurrent.ThreadPoolExecutor.runWorker(Unknown Source)        at java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source)        at java.lang.Thread.run(Unknown Source) main$Quest$144: null

[kornom]

I assume GetEffect method was changed, replaced it with applyEffects

everything works so far!

[Zoey76]

I assume GetEffect method was changed, replaced it with applyEffects

everything works so far!

Yes, I checked, it should work with replacing the 5-6 occurrences of getEffects(..) with applyEffects(..).

[kornom]

I assume GetEffect method was changed, replaced it with applyEffects

everything works so far!

Yes, I checked, it should work with replacing the 5-6 occurrences of getEffects(..) with applyEffects(..).

Works like magic!

Thank you Zoey!

[kornom]

Zoey, could you look in to that unclosed connection error please?

Code: Select all

Unclosed connection! Trace: sun.reflect.GeneratedMethodAccessor17.invoke(Unknown Source)java.lang.RuntimeException        at com.l2jserver.L2DatabaseFactory.getConnection(L2DatabaseFactory.java:180)        at sun.reflect.GeneratedMethodAccessor17.invoke(Unknown Source)        at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)        at java.lang.reflect.Method.invoke(Unknown Source)        at org.python.core.PyReflectedFunction.__call__(Unknown Source)        at org.python.core.PyMethod.__call__(Unknown Source)        at org.python.core.PyObject.__call__(Unknown Source)        at org.python.core.PyInstance.invoke(Unknown Source)        at org.python.pycode.serializable._pyx1387637424222.onAdvEvent$14(custom/555_NPCBUFFER/__init__.py:699)        at org.python.pycode.serializable._pyx1387637424222.call_function(custom/555_NPCBUFFER/__init__.py)        at org.python.core.PyTableCode.call(Unknown Source)        at org.python.core.PyTableCode.call(Unknown Source)        at org.python.core.PyTableCode.call(Unknown Source)        at org.python.core.PyFunction.__call__(Unknown Source)        at org.python.core.PyMethod.__call__(Unknown Source)        at org.python.core.PyObject.__call__(Unknown Source)        at org.python.core.PyObject._jcallexc(Unknown Source)        at org.python.core.PyObject._jcall(Unknown Source)        at org.python.proxies.main$Quest$140.onAdvEvent(Unknown Source)        at com.l2jserver.gameserver.model.quest.Quest.notifyEvent(Quest.java:558)        at com.l2jserver.gameserver.model.actor.instance.L2PcInstance.processQuestEvent(L2PcInstance.java:1688)        at handlers.bypasshandlers.QuestLink.useBypass(QuestLink.java:72)        at com.l2jserver.gameserver.network.clientpackets.RequestBypassToServer.runImpl(RequestBypassToServer.java:340)        at com.l2jserver.gameserver.network.clientpackets.L2GameClientPacket.run(L2GameClientPacket.java:70)        at com.l2jserver.gameserver.network.L2GameClient.run(L2GameClient.java:1133)        at java.util.concurrent.ThreadPoolExecutor.runWorker(Unknown Source)        at java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source)        at java.lang.Thread.run(Unknown Source)

[UnAfraid]

Zoey, could you look in to that unclosed connection error please?

Code: Select all

Unclosed connection! Trace: sun.reflect.GeneratedMethodAccessor17.invoke(Unknown Source)java.lang.RuntimeException        at com.l2jserver.L2DatabaseFactory.getConnection(L2DatabaseFactory.java:180)        at sun.reflect.GeneratedMethodAccessor17.invoke(Unknown Source)        at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)        at java.lang.reflect.Method.invoke(Unknown Source)        at org.python.core.PyReflectedFunction.__call__(Unknown Source)        at org.python.core.PyMethod.__call__(Unknown Source)        at org.python.core.PyObject.__call__(Unknown Source)        at org.python.core.PyInstance.invoke(Unknown Source)        at org.python.pycode.serializable._pyx1387637424222.onAdvEvent$14(custom/555_NPCBUFFER/__init__.py:699)        at org.python.pycode.serializable._pyx1387637424222.call_function(custom/555_NPCBUFFER/__init__.py)        at org.python.core.PyTableCode.call(Unknown Source)        at org.python.core.PyTableCode.call(Unknown Source)        at org.python.core.PyTableCode.call(Unknown Source)        at org.python.core.PyFunction.__call__(Unknown Source)        at org.python.core.PyMethod.__call__(Unknown Source)        at org.python.core.PyObject.__call__(Unknown Source)        at org.python.core.PyObject._jcallexc(Unknown Source)        at org.python.core.PyObject._jcall(Unknown Source)        at org.python.proxies.main$Quest$140.onAdvEvent(Unknown Source)        at com.l2jserver.gameserver.model.quest.Quest.notifyEvent(Quest.java:558)        at com.l2jserver.gameserver.model.actor.instance.L2PcInstance.processQuestEvent(L2PcInstance.java:1688)        at handlers.bypasshandlers.QuestLink.useBypass(QuestLink.java:72)        at com.l2jserver.gameserver.network.clientpackets.RequestBypassToServer.runImpl(RequestBypassToServer.java:340)        at com.l2jserver.gameserver.network.clientpackets.L2GameClientPacket.run(L2GameClientPacket.java:70)        at com.l2jserver.gameserver.network.L2GameClient.run(L2GameClient.java:1133)        at java.util.concurrent.ThreadPoolExecutor.runWorker(Unknown Source)        at java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source)        at java.lang.Thread.run(Unknown Source)

Not closed connections in your buffer.
Use this one instead viewtopic.php?f=13&t=26578

[Zoey76]

In line 385 is missing:

Code: Select all

        try : conn.close()        except : pass

In line 703 (after you added the other lines)

Code: Select all

if param == "no_name" :   try : conn.close()   except : pass

Indentation is important.

[kornom]

Code: Select all

            HTML_MESSAGE += "<br><font color=\"303030\">"+TITLE_NAME+"</font></body></html>"            return HTML_MESSAGE            try : conn.close()            except : pass                def generateQuery(case,case2) :

Code: Select all

        if event == "create" :            con=L2DatabaseFactory.getInstance().getConnection()            param = eventParam1.replace("."," ")            if param == "no_name" :            try : conn.close()            except : pass                return showText(st,"Info","Please, enter the scheme name!","True","Return","main")            else :                ins = con.prepareStatement("INSERT INTO buffer_scheme_list (player_id,scheme_name) VALUES (?,?)")                ins.setString(1, str(st.player.getObjectId()))                ins.setString(2, param)                try :

Like that?