[skill_name] field in [clan_skills] table

[reblock]

Hello. Can you help me. Why do we need [skill_name] field in [clan_skills] table?

[Makc406]

This field is not required there.
Most likely left from the previous server/dp rev.

[jurchiks]

what kind of a stupid question is that?
It's so you wouldn't need to search for the name in xml's or client's .dat files

[reblock]

This field is not required there.
Most likely left from the previous server/dp rev.

Thank you. Are you sure, that this field is not in use anymore? I am transferring database from PTS to L2J server. It's very strange, that table contains skill name (why someone add it???).

what kind of a stupid question is that?
It's so you wouldn't need to search for the name in xml's or client's .dat files

Ok. Why there is no item names in character_items table, skill names in character_skills table etc?) *sarcasm* )

[Makc406]

But why developer's delete same filed from character_skills (http://www.l2jdp.com/trac/changeset?new ... sql%405992)?
Becouse this field already is not needed. In core and dp them not used.

Thank you. Are you sure, that this field is not in use anymore? I am transferring database from PTS to L2J server. It's very strange, that table contains skill name (why someone add it???).

Maybe in PTS is used.

[jurchiks]

what kind of a stupid question is that?
It's so you wouldn't need to search for the name in xml's or client's .dat files

Ok. Why there is no item names in character_items table, skill names in character_skills table etc?) *sarcasm* )

Because those item/skill names are in weapon,armor,etcitem,skill_trees, whilst clan skills are not in sqls.

But why developer's delete same filed from character_skills (http://www.l2jdp.com/trac/changeset?new ... sql%405992)?
Becouse this field already is not needed. In core and dp them not used.

Thank you. Are you sure, that this field is not in use anymore? I am transferring database from PTS to L2J server. It's very strange, that table contains skill name (why someone add it???).

Maybe in PTS is used.

he asked about clan_skills though...

[Makc406]

what kind of a stupid question is that?
It's so you wouldn't need to search for the name in xml's or client's .dat files

Ok. Why there is no item names in character_items table, skill names in character_skills table etc?) *sarcasm* )

Because those item/skill names are in weapon,armor,etcitem,skill_trees, whilst clan skills are not in sqls.

Clan skill names is in pledge_skill_trees.

[jurchiks]

Ok so they are in database. What now?

[Makc406]

Ok so they are in database. What now?

Nothing. Just I has a little correct you post.
--
Sorry, offtopic:
Jurchiks, why you such aggressive to new users of community?

[reblock]

Sorry for my opinion, but I think, that it is stupid to dublicate needless strings in service tables.
If someone wants to know skill names, he must search it in different place (JOINED SELECT from another table), but not in table, that used by game server.

P. S. There is another things in database, that I can't understand (I used PTS server before).
1. Unique Ids in all t6ables (chars, clans, items). AUTO_INCREMENT field for each table - simple, nice and fast solution.
2. SkillId and SkillLevel in item_attributes table, when there is a augAttributes field. Server still decrypts this field and looks aug options (stat modificators etc). Why do we need specify skill data in another fields? If I'll put one value in augAttributes and different values in augSkillId and augSkillLevel, this row fill be corrupted (useless).
3. 'Type' field in character_recipebook. Server already knows this info (common of dwarf recipe)!
...
Sorry for this post. This is just my thoughts. I understand, how much work many people made to write this server.

[jurchiks]

well if some dev will read your post, maybe they will do smth about it, who knows...
although in this community, things usually move really slow

Максу: да потому что слишком часто задают тупые вопросы (в особенности "почему")...

[janiii]

it is not really such a big issue to have skill names in db. mostly the table is static and doesn't change and has only a few records. the skill names are not loaded by gameserver, so it is only database storage they are using. not a big deal. and if, it has no priority..

[JIV]

2reblock: can auto-increment guarantee different ID in more than one table?

[reblock]

2reblock: can auto-increment guarantee different ID in more than one table?

Why do you need different ids for different entities (that doesn't intersects)? Only if you have wrong architecture.
Items - unique ids from 1 to ...
Clans - unique ids from 1 to ...
Items - unique ids from 1 to ...

Server, written by NCZ0ft, perfectly works with same type of ids (unique ids for one type of objects).

---
What about augSkillId and augSkillLevel in item_attributes?

[janiii]

e.g. in items the owner id is taken from characters or from clans, so they cannot be same.
for augmentations - yeah, somehow that is wrong, because we already have a mapping between augId and skill id-level, so there should be no need for that in db. true.

server written by NCZ0ft has different structure, so you cannot just take data from there and migrate it to l2j. different tables, different data structure, different logic.