SQL exception while saving olympiad fight.

[xone]

If you want to receive support we need this info to help you properly.
» Find Revision
L2J Revision Number:4206
L2JDP Revision Number:7215


ok got this ....

Code: Select all

SQL exception while saving olympiad fight.com.mysql.jdbc.MysqlDataTruncation: Data truncation: Out of range value for column 'time' at row 1        at com.mysql.jdbc.MysqlIO.checkErrorPacket(MysqlIO.java:3561)        at com.mysql.jdbc.MysqlIO.checkErrorPacket(MysqlIO.java:3495)        at com.mysql.jdbc.MysqlIO.sendCommand(MysqlIO.java:1959)        at com.mysql.jdbc.MysqlIO.sqlQueryDirect(MysqlIO.java:2113)        at com.mysql.jdbc.ConnectionImpl.execSQL(ConnectionImpl.java:2693)        at com.mysql.jdbc.PreparedStatement.executeInternal(PreparedStatement.java:2102)        at com.mysql.jdbc.PreparedStatement.execute(PreparedStatement.java:1364)         at com.mchange.v2.c3p0.impl.NewProxyPreparedStatement.execute(NewProxyPreparedStatement.java:989)        at com.l2jserver.gameserver.model.olympiad.OlympiadGame.saveResults(OlympiadGame.java:999)        at com.l2jserver.gameserver.model.olympiad.OlympiadGame.validateWinner(OlympiadGame.java:835)        at com.l2jserver.gameserver.model.olympiad.OlympiadGameTask.run(OlympiadGame.java:1134)        at java.lang.Thread.run(Unknown Source) 

[JIV]

did you modified olympiad settings?

[janiii]

the table definition is wrong. both columns hold time info, so are they different?

Code: Select all

  `start` decimal(20,0) unsigned NOT NULL default '0',  `time` int(10) unsigned NOT NULL default '0',

maybe start was not initiated correctly? imo time column should be able to hold also current time in millis..

[JIV]

because oly fight on default can take max 5 min or so.

[janiii]

then start was not initiated because no oly fight started - disconnected player before teleport?

[JIV]

yea maybe.

[janiii]

then maybe just a check if start is 0, then also fight is 0, else current - start.

Code: Select all

Index: java/com/l2jserver/gameserver/model/olympiad/OlympiadGame.java===================================================================--- java/com/l2jserver/gameserver/model/olympiad/OlympiadGame.java	(revision 4207)+++ java/com/l2jserver/gameserver/model/olympiad/OlympiadGame.java	(working copy)@@ -735,7 +735,9 @@ 		String winner = "draw";  		// Calculate Fight time-		long _fightTime = (System.currentTimeMillis() - _startTime);+		long _fightTime = 0;+		if (_startTime > 0)+			_fightTime = (System.currentTimeMillis() - _startTime);  		if (_playerOne == null && _playerTwo == null) 		{

[JIV]

http://pastebin.com/j9ne5Huu

[JIV]

^^ commit your version.

[xone]

Thanks!

[janiii]

is there a szenario how to reproduce this error?

[xone]

hmmm don't think so .... when I got home ... my GM was fighting at oly, did alt tab ... error on screen ... thats all.

[Gnacik]

just move _startTime = System.currentTimeMillis(); before if (_aborted) return false;, so start time will be set even if fight is aborted.

start time cannot be zero, its timestamp so fights with start=0 in monument will be displayed as 1970-01-01