Multisell Armor Exchanger ?

[momo61]

There is a minor issue on my server that I'm trying to solve.

When people try to exchange dynasty armor main pieces for jeweled dynasty armor pieces while they have the regular dynasty armor piece equiped, the exchanger takes their ingredients but doesnt hand out the armor they are intended to get.

What is the reason for this ? If you need a multisell example, i'll post one here. If you already know whats wrong, then please help out.

peace,

Momo61

[MELERIX]

as I know, you can't exchange items that are equipped, you need to unequip they before try to exchange...

[momo61]

as I know, you can't exchange items that are equipped, you need to unequip they before try to exchange...

I know that, but players dont know that. If you try to exchange with your armor on, you will lose all the ingredients necessary for the trade, but you wont recieve the item you want.

[Probe]

if armor is equipped multisell won't accept the exchange.. at least that's how it works on my server >.<

[janiii]

imho the check for equiped ingredient should be done before destroying any ingredients of the multisell.

[momo61]

if armor is equipped multisell won't accept the exchange.. at least that's how it works on my server >.<

try latest L2J Revision

[_DS_]

imho the check for equiped ingredient should be done before destroying any ingredients of the multisell.

Equipped ingridients not shown in multisell exchange window. If someone trying to exchange equipped item - he is a cheater. And cheaters should be punished.
This is why it perfect for me.

[janiii]

momo, in which multisell did this happen? (npc, item to buy, item equipped, item lost.)

[momo61]

momo, in which multisell did this happen? (npc, item to buy, item equipped, item lost.)

a custom multisell where you trade regular dynasty main piece for improved (jeweled leather) dynasty main piece.

[janiii]

momo, in which multisell did this happen? (npc, item to buy, item equipped, item lost.)

a custom multisell where you trade regular dynasty main piece for improved (jeweled leather) dynasty main piece.

then yeah. l2j dynasty multisells are all exchange multisell which show you only items that are not equipped. so the player gets "punished" with loosing items for that cheating.


but i still think it should be moved before the items get destroyed, so normal multisell doesnt have this "feature" that ingredients get lost and no product is created. only a log entry should be done.


what about craft a dualsword at warsmith? it uses normal multisell and it has a weapon as ingredient.. check retail if it is a exchange multisell or what it does when you have the weapon is equipped.

[_DS_]

then yeah. l2j dynasty multisells are all exchange multisell which show you only items that are not equipped. so the player gets "punished" with loosing items for that cheating.

Check already done during list generation. If someone equip item between exchange and pressing ok - he did it on purpose: cheating.

[janiii]

Check already done during list generation. If someone equip item between exchange and pressing ok - he did it on purpose: cheating.

is it on retail too, that the player is loosing the items when he equips the item between multisell and pressing ok? i doubt that..


and what about this?

what about craft a dualsword at warsmith? it uses normal multisell and it has a weapon as ingredient.. check retail if it is a exchange multisell or what it does when you have the weapon is equipped.

[JIV]

http://trac.assembla.com/L2jOfficial/changeset/1335