Oly hp

[xone]

If you want to receive support we need this info to help you properly.
» Find Revision
L2J Revision Number:4243
L2JDP Revision Number:7451

From player:

can you fix olly? we dont see other players hp at least in 1/2 match
i se hp of different players that have match in different olly zone but not my oponent wtf

anything to do with this ?

java.lang.NullPointerException
at com.l2jserver.gameserver.model.actor.instance.L2PcInstance.checkPvpSk
ill(L2PcInstance.java:9546)
at com.l2jserver.gameserver.model.actor.instance.L2PcInstance.checkPvpSk
ill(L2PcInstance.java:9509)
at com.l2jserver.gameserver.model.actor.instance.L2PcInstance.checkUseMa
gicConditions(L2PcInstance.java:9306)
at com.l2jserver.gameserver.model.actor.instance.L2PcInstance.useMagic(L
2PcInstance.java:8830)
at com.l2jserver.gameserver.network.clientpackets.RequestMagicSkillUse.r
unImpl(RequestMagicSkillUse.java:91)
at com.l2jserver.gameserver.network.clientpackets.L2GameClientPacket.run
(L2GameClientPacket.java:92)
at java.util.concurrent.ThreadPoolExecutor$Worker.runTask(Unknown Source
)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source)
at java.lang.Thread.run(Unknown Source)

[JIV]

and what you have on
at com.l2jserver.gameserver.model.actor.instance.L2PcInstance.checkPvpSk
ill(L2PcInstance.java:9546)

[xone]

L2PcInstance ... really dont know for what to look ... im kinda noob with java ...

Code: Select all

switch (sklTargetType)		{			case TARGET_PARTY:			case TARGET_ALLY:   // For such skills, checkPvpSkill() is called from L2Skill.getTargetList()			case TARGET_CLAN:   // For such skills, checkPvpSkill() is called from L2Skill.getTargetList()			case TARGET_PARTY_CLAN:   // For such skills, checkPvpSkill() is called from L2Skill.getTargetList()			case TARGET_AURA:			case TARGET_FRONT_AURA:			case TARGET_BEHIND_AURA:			case TARGET_GROUND:			case TARGET_SELF:				break;			default:				if (!checkPvpSkill(target, skill) && !getAccessLevel().allowPeaceAttack())				{					// Send a System Message to the L2PcInstance					sendPacket(new SystemMessage(SystemMessageId.TARGET_IS_INCORRECT)); 					// Send a Server->Client packet ActionFailed to the L2PcInstance					sendPacket(ActionFailed.STATIC_PACKET);					return false;				}		}

Code: Select all

	/**	 * Check if the requested casting is a Pc->Pc skill cast and if it's a valid pvp condition	 * @param target L2Object instance containing the target	 * @param skill L2Skill instance with the skill being casted	 * @return False if the skill is a pvpSkill and target is not a valid pvp target	 */	public boolean checkPvpSkill(L2Object target, L2Skill skill)	{		return checkPvpSkill(target, skill, false);	} 	/**	 * Check if the requested casting is a Pc->Pc skill cast and if it's a valid pvp condition	 * @param target L2Object instance containing the target	 * @param skill L2Skill instance with the skill being casted	 * @param srcIsSummon is L2Summon - caster?	 * @return False if the skill is a pvpSkill and target is not a valid pvp target	 */	public boolean checkPvpSkill(L2Object target, L2Skill skill, boolean srcIsSummon)	{		// check for PC->PC Pvp status		if(target instanceof L2Summon)			target = target.getActingPlayer();		if (				target != null &&                                           			// target not null and				target != this &&                                           			// target is not self and				target instanceof L2PcInstance &&                           			// target is L2PcInstance and				!(isInDuel() && ((L2PcInstance)target).getDuelId() == getDuelId()) &&	// self is not in a duel and attacking opponent				!isInsideZone(ZONE_PVP) &&        						// Pc is not in PvP zone				!((L2PcInstance)target).isInsideZone(ZONE_PVP)         	// target is not in PvP zone		)		{			if(skill.isPvpSkill()) // pvp skill			{				if(getClan() != null && ((L2PcInstance)target).getClan() != null)				{					if(getClan().isAtWarWith(((L2PcInstance)target).getClan().getClanId()) && ((L2PcInstance)target).getClan().isAtWarWith(getClan().getClanId()))						return true; // in clan war player can attack whites even with sleep etc.				}				if (						((L2PcInstance)target).getPvpFlag() == 0 &&             //   target's pvp flag is not set and						((L2PcInstance)target).getKarma() == 0                  //   target has no karma					)					return false;			}			else if ((getCurrentSkill() != null && !getCurrentSkill().isCtrlPressed() && skill.isOffensive() && !srcIsSummon) 					|| (getCurrentPetSkill() != null && !getCurrentPetSkill().isCtrlPressed() && skill.isOffensive() && srcIsSummon))			{				if(getClan() != null && ((L2PcInstance)target).getClan() != null)				{					if(getClan().isAtWarWith(((L2PcInstance)target).getClan().getClanId()) && ((L2PcInstance)target).getClan().isAtWarWith(getClan().getClanId()))						return true; // in clan war player can attack whites even without ctrl				}				if (						((L2PcInstance)target).getPvpFlag() == 0 &&             //   target's pvp flag is not set and						((L2PcInstance)target).getKarma() == 0                  //   target has no karma					)					return false;			}		} 		return true;	}

[janiii]

what code do you have in L2PcInstance.java at line 9546. that code parts dont help us..

[JIV]

you must wrote line 9546
enable line count or check down in statusbar.

[xone]

did bold and put near 9546

Code: Select all

	/**	 * Check if the requested casting is a Pc->Pc skill cast and if it's a valid pvp condition	 * @param target L2Object instance containing the target	 * @param skill L2Skill instance with the skill being casted	 * @return False if the skill is a pvpSkill and target is not a valid pvp target	 */	public boolean checkPvpSkill(L2Object target, L2Skill skill)	{		return checkPvpSkill(target, skill, false);	} 	/**	 * Check if the requested casting is a Pc->Pc skill cast and if it's a valid pvp condition	 * @param target L2Object instance containing the target	 * @param skill L2Skill instance with the skill being casted	 * @param srcIsSummon is L2Summon - caster?	 * @return False if the skill is a pvpSkill and target is not a valid pvp target	 */	public boolean checkPvpSkill(L2Object target, L2Skill skill, boolean srcIsSummon)	{		// check for PC->PC Pvp status		if(target instanceof L2Summon)			target = target.getActingPlayer();		if (				target != null &&                                           			// target not null and				target != this &&                                           			// target is not self and				target instanceof L2PcInstance &&                           			// target is L2PcInstance and				!(isInDuel() && ((L2PcInstance)target).getDuelId() == getDuelId()) &&	// self is not in a duel and attacking opponent				!isInsideZone(ZONE_PVP) &&        						// Pc is not in PvP zone				!((L2PcInstance)target).isInsideZone(ZONE_PVP)         	// target is not in PvP zone		)		{			if(skill.isPvpSkill()) // pvp skill			{				if(getClan() != null && ((L2PcInstance)target).getClan() != null)				{					if(getClan().isAtWarWith(((L2PcInstance)target).getClan().getClanId()) && ((L2PcInstance)target).getClan().isAtWarWith(getClan().getClanId()))						return true; // in clan war player can attack whites even with sleep etc.				}				if (						((L2PcInstance)target).getPvpFlag() == 0 &&             //   target's pvp flag is not set and						((L2PcInstance)target).getKarma() == 0                  //   target has no karma					)					return false;			}	9546		[b]else if ((getCurrentSkill() != null && !getCurrentSkill().isCtrlPressed() && skill.isOffensive() && !srcIsSummon) [/b]					|| (getCurrentPetSkill() != null && !getCurrentPetSkill().isCtrlPressed() && skill.isOffensive() && srcIsSummon))			{				if(getClan() != null && ((L2PcInstance)target).getClan() != null)				{					if(getClan().isAtWarWith(((L2PcInstance)target).getClan().getClanId()) && ((L2PcInstance)target).getClan().isAtWarWith(getClan().getClanId()))						return true; // in clan war player can attack whites even without ctrl				}				if (						((L2PcInstance)target).getPvpFlag() == 0 &&             //   target's pvp flag is not set and						((L2PcInstance)target).getKarma() == 0                  //   target has no karma					)					return false;			}		} 		return true;	}

[JIV]

should help
http://www.l2jserver.com/trac/changeset/4244

[xone]

Sure, thank you!

[janiii]

i can see there already a null check for getCurrentSkill(). maybe variable skill was null?

[JIV]

if skill would be null then it fail on skill.isPvpSkill() (9359). in aborCast getCurrentSkill() is set to null so its probably from there.

[xone]

Got this just now ...

PS: I didnt update to Changeset 4244 yet .

Error could not store char skills: An SQLException was provoked by the following
failure: java.lang.InterruptedException
java.sql.SQLException: An SQLException was provoked by the following failure: ja
va.lang.InterruptedException
at com.mchange.v2.sql.SqlUtils.toSQLException(SqlUtils.java:106)
at com.mchange.v2.sql.SqlUtils.toSQLException(SqlUtils.java:65)
at com.mchange.v2.sql.SqlUtils.toSQLException(SqlUtils.java:62)
at com.mchange.v2.c3p0.stmt.GooGooStatementCache.acquireStatement(GooGoo
StatementCache.java:562)
at com.mchange.v2.c3p0.stmt.GooGooStatementCache.checkoutStatement(GooGo
oStatementCache.java:168)
at com.mchange.v2.c3p0.impl.NewPooledConnection.checkoutStatement(NewPoo
ledConnection.java:277)
at com.mchange.v2.c3p0.impl.NewProxyConnection.prepareStatement(NewProxy
Connection.java:199)
at com.l2jserver.gameserver.model.actor.instance.L2PcInstance.storeSkill
(L2PcInstance.java:8203)
at com.l2jserver.gameserver.model.actor.instance.L2PcInstance.addSkill(L
2PcInstance.java:8086)
at com.l2jserver.gameserver.model.actor.instance.L2PcInstance.giveAvaila
bleSkills(L2PcInstance.java:3019)
at com.l2jserver.gameserver.model.actor.instance.L2PcInstance.rewardSkil
ls(L2PcInstance.java:2932)
at com.l2jserver.gameserver.model.actor.stat.PcStat.addLevel(PcStat.java
:220)
at com.l2jserver.gameserver.model.actor.stat.PlayableStat.addExp(Playabl
eStat.java:67)
at com.l2jserver.gameserver.model.actor.stat.PcStat.addExp(PcStat.java:7
0)
at com.l2jserver.gameserver.model.actor.stat.PlayableStat.addExpAndSp(Pl
ayableStat.java:103)
at com.l2jserver.gameserver.model.actor.stat.PcStat.addExpAndSp(PcStat.j
ava:127)
at com.l2jserver.gameserver.model.actor.stat.PcStat.addExpAndSp(PcStat.j
ava:170)
at com.l2jserver.gameserver.model.actor.instance.L2PcInstance.addExpAndS
p(L2PcInstance.java:11444)
at com.l2jserver.gameserver.model.L2Party.distributeXpAndSp(L2Party.java
:696)
at com.l2jserver.gameserver.model.actor.L2Attackable.calculateRewards(L2
Attackable.java:849)
at com.l2jserver.gameserver.model.actor.L2Character.doDie(L2Character.ja
va:2131)
at com.l2jserver.gameserver.model.actor.L2Npc.doDie(L2Npc.java:1388)
at com.l2jserver.gameserver.model.actor.L2Attackable.doDie(L2Attackable.
java:505)
at com.l2jserver.gameserver.model.actor.instance.L2MonsterInstance.doDie
(L2MonsterInstance.java:207)
at handlers.skillhandlers.Mdam.useSkill(Mdam.java:205)
at com.l2jserver.gameserver.model.actor.L2Character.callSkill(L2Characte
r.java:6554)
at com.l2jserver.gameserver.model.actor.L2Character.onMagicHitTimer(L2Ch
aracter.java:6142)
at com.l2jserver.gameserver.model.actor.L2Character$MagicUseTask.run(L2C
haracter.java:2596)
at java.util.concurrent.Executors$RunnableAdapter.call(Unknown Source)
at java.util.concurrent.FutureTask$Sync.innerRun(Unknown Source)
at java.util.concurrent.FutureTask.run(Unknown Source)
at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.
access$301(Unknown Source)
at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.
run(Unknown Source)
at java.util.concurrent.ThreadPoolExecutor$Worker.runTask(Unknown Source
)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source)
at java.lang.Thread.run(Unknown Source)
Caused by: java.lang.InterruptedException
at java.lang.Object.wait(Native Method)
at java.lang.Object.wait(Object.java:485)
at com.mchange.v2.c3p0.stmt.GooGooStatementCache.acquireStatement(GooGoo
StatementCache.java:552)
... 32 more