DEVELOPER TASKS

Read me first before posting anywhere!
Forum rules
READ NOW: L2j Forums Rules of Conduct
Locked
User avatar
Zoey76
L2j Inner Circle
L2j Inner Circle
Posts: 7008
Joined: Tue Aug 11, 2009 3:36 am

Re: DEVELOPER TASKS

Post by Zoey76 »

Updated Adry_85 and my tasks.
Powered by Eclipse 4.34 ๐ŸŒŒ | Eclipse Temurin 21 โ˜• | MariaDB 11.3.2 ๐Ÿ—ƒ๏ธ | L2J Server 2.6.3.0 - High Five ๐Ÿš€

๐Ÿ”— Join our Discord! ๐ŸŽฎ๐Ÿ’ฌ
User avatar
UnAfraid
L2j Veteran
L2j Veteran
Posts: 4199
Joined: Mon Jul 23, 2007 4:25 pm
Location: Bulgaria
Contact:

Re: DEVELOPER TASKS

Post by UnAfraid »

Stealing task 'Fix/Update all Agathion summon skills' from Zoey76 and transferring it to Adry_85.
Image
User avatar
Zoey76
L2j Inner Circle
L2j Inner Circle
Posts: 7008
Joined: Tue Aug 11, 2009 3:36 am

Re: DEVELOPER TASKS

Post by Zoey76 »

UnAfraid wrote:Stealing task 'Fix/Update all Agathion summon skills' from Zoey76 and transferring it to Adry_85.
Don't, I have it done already, beside Adry_85 has lot of tasks already :lol:

You actually need to ask me to move a task from my list, otherwise there is no point on having the task assigned.
Powered by Eclipse 4.34 ๐ŸŒŒ | Eclipse Temurin 21 โ˜• | MariaDB 11.3.2 ๐Ÿ—ƒ๏ธ | L2J Server 2.6.3.0 - High Five ๐Ÿš€

๐Ÿ”— Join our Discord! ๐ŸŽฎ๐Ÿ’ฌ
User avatar
Zoey76
L2j Inner Circle
L2j Inner Circle
Posts: 7008
Joined: Tue Aug 11, 2009 3:36 am

Re: DEVELOPER TASKS

Post by Zoey76 »

Added one task to UnAfraid related to a changeset.
Powered by Eclipse 4.34 ๐ŸŒŒ | Eclipse Temurin 21 โ˜• | MariaDB 11.3.2 ๐Ÿ—ƒ๏ธ | L2J Server 2.6.3.0 - High Five ๐Ÿš€

๐Ÿ”— Join our Discord! ๐ŸŽฎ๐Ÿ’ฌ
User avatar
Zoey76
L2j Inner Circle
L2j Inner Circle
Posts: 7008
Joined: Tue Aug 11, 2009 3:36 am

Re: DEVELOPER TASKS

Post by Zoey76 »

Updated my tasks after yesterday's commits and added one task to malyelfik.
Powered by Eclipse 4.34 ๐ŸŒŒ | Eclipse Temurin 21 โ˜• | MariaDB 11.3.2 ๐Ÿ—ƒ๏ธ | L2J Server 2.6.3.0 - High Five ๐Ÿš€

๐Ÿ”— Join our Discord! ๐ŸŽฎ๐Ÿ’ฌ
User avatar
Zoey76
L2j Inner Circle
L2j Inner Circle
Posts: 7008
Joined: Tue Aug 11, 2009 3:36 am

Re: DEVELOPER TASKS

Post by Zoey76 »

Done: Fix/Update all Agathion summon skills in Changeset 5696 and DP Changeset 9281.
Powered by Eclipse 4.34 ๐ŸŒŒ | Eclipse Temurin 21 โ˜• | MariaDB 11.3.2 ๐Ÿ—ƒ๏ธ | L2J Server 2.6.3.0 - High Five ๐Ÿš€

๐Ÿ”— Join our Discord! ๐ŸŽฎ๐Ÿ’ฌ
User avatar
Zoey76
L2j Inner Circle
L2j Inner Circle
Posts: 7008
Joined: Tue Aug 11, 2009 3:36 am

Re: DEVELOPER TASKS

Post by Zoey76 »

Added a couple of bugs to fix to my list related to my work :lol:
Powered by Eclipse 4.34 ๐ŸŒŒ | Eclipse Temurin 21 โ˜• | MariaDB 11.3.2 ๐Ÿ—ƒ๏ธ | L2J Server 2.6.3.0 - High Five ๐Ÿš€

๐Ÿ”— Join our Discord! ๐ŸŽฎ๐Ÿ’ฌ
User avatar
Zoey76
L2j Inner Circle
L2j Inner Circle
Posts: 7008
Joined: Tue Aug 11, 2009 3:36 am

Re: DEVELOPER TASKS

Post by Zoey76 »

Added new unassigned task:
More retail like implementation of viewtopic.php?f=41&t=26543
  • Rename TARGET_ALLY to TARGET_ALLY_AURA due it's behaviour.
  • Implement TARGET_NEUTRAL_AREA that should return all neutral players (ally, clan, party, non chaotic) around any given target.
  • Change Chain Heal to sue this new target type and remove the TODO tast in XML.
  • If possible move Chain Heal from skill handler to datapack.
It'd be nice if Nik or UnAfraid take over this taks, since you guys did the first implementation.

Updated :D
Powered by Eclipse 4.34 ๐ŸŒŒ | Eclipse Temurin 21 โ˜• | MariaDB 11.3.2 ๐Ÿ—ƒ๏ธ | L2J Server 2.6.3.0 - High Five ๐Ÿš€

๐Ÿ”— Join our Discord! ๐ŸŽฎ๐Ÿ’ฌ
User avatar
MELERIX
L2j Veteran
L2j Veteran
Posts: 6667
Joined: Sat Sep 23, 2006 11:31 pm
Location: Chile
Contact:

Re: DEVELOPER TASKS

Post by MELERIX »

also don't forget support for "affect_limit" that is missing for "Chain Heal" and others skills too.

affect_limit is min-max target to affect (randomly).
User avatar
Zoey76
L2j Inner Circle
L2j Inner Circle
Posts: 7008
Joined: Tue Aug 11, 2009 3:36 am

Re: DEVELOPER TASKS

Post by Zoey76 »

MELERIX wrote:also don't forget support for "affect_limit" that is missing for "Chain Heal" and others skills too.

affect_limit is min-max target to affect (randomly).
I think that almost all pole skile use affect_limit parameter.
Powered by Eclipse 4.34 ๐ŸŒŒ | Eclipse Temurin 21 โ˜• | MariaDB 11.3.2 ๐Ÿ—ƒ๏ธ | L2J Server 2.6.3.0 - High Five ๐Ÿš€

๐Ÿ”— Join our Discord! ๐ŸŽฎ๐Ÿ’ฌ
User avatar
UnAfraid
L2j Veteran
L2j Veteran
Posts: 4199
Joined: Mon Jul 23, 2007 4:25 pm
Location: Bulgaria
Contact:

Re: DEVELOPER TASKS

Post by UnAfraid »

Zoey76 wrote:
MELERIX wrote:also don't forget support for "affect_limit" that is missing for "Chain Heal" and others skills too.

affect_limit is min-max target to affect (randomly).
I think that almost all pole skile use affect_limit parameter.
Can someone confirm if pole master's passive skill that increases amount of targets that he can attack is included in skills.
I can parse affect limit and implement it but i need some info..
Image
User avatar
MELERIX
L2j Veteran
L2j Veteran
Posts: 6667
Joined: Sat Sep 23, 2006 11:31 pm
Location: Chile
Contact:

Re: DEVELOPER TASKS

Post by MELERIX »

affect_limit is for area related skills (how min and max players are affected inside the area randomly).

not related with poles as I know.
User avatar
Adry_85
DP Team Leader
DP Team Leader
Posts: 742
Joined: Thu Jun 15, 2006 10:00 am

Re: DEVELOPER TASKS

Post by Adry_85 »

Yes, is not related with a pole :)
Image
User avatar
UnAfraid
L2j Veteran
L2j Veteran
Posts: 4199
Joined: Mon Jul 23, 2007 4:25 pm
Location: Bulgaria
Contact:

Re: DEVELOPER TASKS

Post by UnAfraid »

Its not about relation with pole.
Here we have a skill that inceases amount of targets for the pole master i want to know if that skill affects other skills or just plain attack.
Image
User avatar
VlLight
L2j Veteran
L2j Veteran
Posts: 577
Joined: Fri Dec 14, 2007 11:58 am
Location: Russia

Re: DEVELOPER TASKS

Post by VlLight »

If you mean "p_hit_number" parameter ("atkCountMax" in L2J), it applies only to physical attack. AFAIK
Locked