Core cleanup suggestion...

[theone]

Hello everyone,
For a long time alot of people(me included) have been saying: "The core should be cleaned up, there's alot of dead code and duplicates in there", etc...
But no one seems to want to do it or to know where to start.
In an effort to jumpstart the discussion on this subject I've run the /model/actor/instance part of the core against an "unused code detector".
This "unused code detector" produces an output that not only tells you about the "dead code" but also makes suggestions about what public methods/constants/variables should be made private. I overlooked this aspect because it's not what interests us here really.
I'll post here the results of the scanner, just to give you an idea how much dead code is in there... (keep in mind that some of those methods/constants/fields are perhaps used in the datapack, so removing them should be done carefully!)

Code: Select all

com.l2jserver.gameserver.model.actor.instance.L2VillageMasterDwarfInstance.<init>(L2VillageMasterDwarfInstance.java:21) Class "L2VillageMasterDwarfInstance" has 0 references   L2VillageMasterDwarfInstance    org.ucdetector.analyzeMarkerReference   com.l2jserver.gameserver.model.actor.instance.L2PcInstance.soulShotLock(L2PcInstance.java:751)  Field "L2PcInstance.soulShotLock" has 0 references  L2PcInstance.soulShotLock   org.ucdetector.analyzeMarkerReference   Yesodcom.l2jserver.gameserver.model.actor.instance.L2PcInstance.createDummyPlayer(L2PcInstance.java:1105)    Method "L2PcInstance.createDummyPlayer(int,String)" has 0 references    L2PcInstance.createDummyPlayer(int,String)  org.ucdetector.analyzeMarkerReference   Yesodcom.l2jserver.gameserver.model.actor.instance.L2PcInstance.getQuestsForAttacks(L2PcInstance.java:1677)  Method "L2PcInstance.getQuestsForAttacks(L2Npc)" has 0 references   L2PcInstance.getQuestsForAttacks(L2Npc) org.ucdetector.analyzeMarkerReference   Yesodcom.l2jserver.gameserver.model.actor.instance.L2PcInstance.getQuestsForKills(L2PcInstance.java:1704)    Method "L2PcInstance.getQuestsForKills(L2Npc)" has 0 references L2PcInstance.getQuestsForKills(L2Npc)   org.ucdetector.analyzeMarkerReference   Yesodcom.l2jserver.gameserver.model.actor.instance.L2PcInstance.getShortCut(L2PcInstance.java:1888)  Method "L2PcInstance.getShortCut(int,int)" has 0 references L2PcInstance.getShortCut(int,int)   org.ucdetector.analyzeMarkerReference   Yesodcom.l2jserver.gameserver.model.actor.instance.L2PcInstance.hasCommonCraft(L2PcInstance.java:2104)   Method "L2PcInstance.hasCommonCraft()" has 0 references L2PcInstance.hasCommonCraft()   org.ucdetector.analyzeMarkerReference   Yesodcom.l2jserver.gameserver.model.actor.instance.L2PcInstance.checkIfWeaponIsAllowed(L2PcInstance.java:2432)   Method "L2PcInstance.checkIfWeaponIsAllowed()" has 0 references L2PcInstance.checkIfWeaponIsAllowed()   org.ucdetector.analyzeMarkerReference   Yesodcom.l2jserver.gameserver.model.actor.instance.L2PcInstance.isCastleLord(L2PcInstance.java:3049) Method "L2PcInstance.isCastleLord(int)" has 0 references    L2PcInstance.isCastleLord(int)  org.ucdetector.analyzeMarkerReference   Yesodcom.l2jserver.gameserver.model.actor.instance.L2PcInstance.destroyItemWithoutTrace(L2PcInstance.java:3872)  Method "L2PcInstance.destroyItemWithoutTrace(String,int,long,L2Object,boolean)" has 0 references    L2PcInstance.destroyItemWithoutTrace(String,int,long,L2Object,boolean)  org.ucdetector.analyzeMarkerReference   Yesodcom.l2jserver.gameserver.model.actor.instance.L2PcInstance.transformSelectInfo(L2PcInstance.java:5176)  Method "L2PcInstance.transformSelectInfo()" has 0 references    L2PcInstance.transformSelectInfo()  org.ucdetector.analyzeMarkerReference   Yesodcom.l2jserver.gameserver.model.actor.instance.L2PcInstance.disableAutoShotByCrystalType(L2PcInstance.java:9990) Method "L2PcInstance.disableAutoShotByCrystalType(int)" has 0 references    L2PcInstance.disableAutoShotByCrystalType(int)  org.ucdetector.analyzeMarkerReference   Yesodcom.l2jserver.gameserver.model.actor.instance.L2PcInstance.enterObserverMode(L2PcInstance.java:10182)   Method "L2PcInstance.enterObserverMode(int,int,int)" has 0 references   L2PcInstance.enterObserverMode(int,int,int) org.ucdetector.analyzeMarkerReference   Yesodcom.l2jserver.gameserver.model.actor.instance.L2PcInstance.enterOlympiadObserverMode(L2PcInstance.java:10210)   Method "L2PcInstance.enterOlympiadObserverMode(Location,int)" has 0 references  L2PcInstance.enterOlympiadObserverMode(Location,int)    org.ucdetector.analyzeMarkerReference   Yesodcom.l2jserver.gameserver.model.actor.instance.L2PcInstance.setLoto(L2PcInstance.java:10345) Method "L2PcInstance.setLoto(int,int)" has 0 references L2PcInstance.setLoto(int,int)   org.ucdetector.analyzeMarkerReference   Yesodcom.l2jserver.gameserver.model.actor.instance.L2PcInstance.getLoto(L2PcInstance.java:10350) Method "L2PcInstance.getLoto(int)" has 0 references L2PcInstance.getLoto(int)   org.ucdetector.analyzeMarkerReference   Yesodcom.l2jserver.gameserver.model.actor.instance.L2PcInstance.startRentPet(L2PcInstance.java:11082)    Method "L2PcInstance.startRentPet(int)" has 0 references    L2PcInstance.startRentPet(int)  org.ucdetector.analyzeMarkerReference   Yesodcom.l2jserver.gameserver.model.actor.instance.L2PcInstance.checkLastServerPosition(L2PcInstance.java:11457) Method "L2PcInstance.checkLastServerPosition(int,int,int)" has 0 references L2PcInstance.checkLastServerPosition(int,int,int)   org.ucdetector.analyzeMarkerReference   Yesodcom.l2jserver.gameserver.model.actor.instance.L2PcInstance.getLastServerDistance(L2PcInstance.java:11462)   Method "L2PcInstance.getLastServerDistance(int,int,int)" has 0 references   L2PcInstance.getLastServerDistance(int,int,int) org.ucdetector.analyzeMarkerReference   Yesodcom.l2jserver.gameserver.model.actor.instance.L2PcInstance.removeExpAndSp(L2PcInstance.java:11482)  Method "L2PcInstance.removeExpAndSp(long,int)" has 0 references L2PcInstance.removeExpAndSp(long,int)   org.ucdetector.analyzeMarkerReference   Yesodcom.l2jserver.gameserver.model.actor.instance.L2PcInstance.removeExpAndSp(L2PcInstance.java:11487)  Method "L2PcInstance.removeExpAndSp(long,int,boolean)" has 0 references L2PcInstance.removeExpAndSp(long,int,boolean)   org.ucdetector.analyzeMarkerReference   Yesodcom.l2jserver.gameserver.model.actor.instance.L2PcInstance.addSnooper(L2PcInstance.java:11518)  Method "L2PcInstance.addSnooper(L2PcInstance)" has 0 references L2PcInstance.addSnooper(L2PcInstance)   org.ucdetector.analyzeMarkerReference   Yesodcom.l2jserver.gameserver.model.actor.instance.L2PcInstance.addSnooped(L2PcInstance.java:11529)  Method "L2PcInstance.addSnooped(L2PcInstance)" has 0 references L2PcInstance.addSnooped(L2PcInstance)   org.ucdetector.analyzeMarkerReference   Yesodcom.l2jserver.gameserver.model.actor.instance.L2PcInstance.startFishing(L2PcInstance.java:12186)    Method "L2PcInstance.startFishing(int,int,int)" has 0 references    L2PcInstance.startFishing(int,int,int)  org.ucdetector.analyzeMarkerReference   Yesodcom.l2jserver.gameserver.model.actor.instance.L2PcInstance.shortBuffStatusUpdate(L2PcInstance.java:13182)   Method "L2PcInstance.shortBuffStatusUpdate(int,int,int)" has 0 references   L2PcInstance.shortBuffStatusUpdate(int,int,int) org.ucdetector.analyzeMarkerReference   Yesodcom.l2jserver.gameserver.model.actor.instance.L2PcInstance.reduceDeathPenaltyBuffLevel(L2PcInstance.java:13244) Method "L2PcInstance.reduceDeathPenaltyBuffLevel()" has 0 references    L2PcInstance.reduceDeathPenaltyBuffLevel()  org.ucdetector.analyzeMarkerReference   Yesodcom.l2jserver.gameserver.model.actor.instance.L2PcInstance._shortBuffTaskSkillId(L2PcInstance.java:12585)   Field "L2PcInstance._shortBuffTaskSkillId" is never read    L2PcInstance._shortBuffTaskSkillId  org.ucdetector.analyzeMarkerReference   Yesodcom.l2jserver.gameserver.model.actor.instance.L2PcInstance.teleportRequest(L2PcInstance.java:13505) Method "L2PcInstance.teleportRequest(L2PcInstance,L2Skill)" has 0 references    L2PcInstance.teleportRequest(L2PcInstance,L2Skill)  org.ucdetector.analyzeMarkerReference   Yesodcom.l2jserver.gameserver.model.actor.instance.L2PcInstance.gatesRequest(L2PcInstance.java:13697)    Method "L2PcInstance.gatesRequest(L2DoorInstance)" has 0 references L2PcInstance.gatesRequest(L2DoorInstance)   org.ucdetector.analyzeMarkerReference   Yesodcom.l2jserver.gameserver.model.actor.instance.L2PcInstance.showQuestMovie(L2PcInstance.java:14541)  Method "L2PcInstance.showQuestMovie(int)" has 0 references  L2PcInstance.showQuestMovie(int)    org.ucdetector.analyzeMarkerReference   Yesodcom.l2jserver.gameserver.model.actor.instance.L2PcInstance.addSilenceModeExcluded(L2PcInstance.java:14708)  Method "L2PcInstance.addSilenceModeExcluded(int)" has 0 references  L2PcInstance.addSilenceModeExcluded(int)    org.ucdetector.analyzeMarkerReference   Yesodcom.l2jserver.gameserver.model.actor.instance.L2PcInstance.canAttackCharacter(L2PcInstance.java:15093)  Method "L2PcInstance.canAttackCharacter(L2Character)" has 0 references  L2PcInstance.canAttackCharacter(L2Character)    org.ucdetector.analyzeMarkerReference   Yesodcom.l2jserver.gameserver.model.actor.instance.L2PcInstance.updateNotMoveUntil(L2PcInstance.java:15420)  Method "L2PcInstance.updateNotMoveUntil()" has 0 references L2PcInstance.updateNotMoveUntil()   org.ucdetector.analyzeMarkerReference   Yesodcom.l2jserver.gameserver.model.actor.instance.L2FlyMonsterInstance.<init>(L2FlyMonsterInstance.java:19) Class "L2FlyMonsterInstance" has 0 references   L2FlyMonsterInstance    org.ucdetector.analyzeMarkerReference   com.l2jserver.gameserver.model.actor.instance.L2SiegeFlagInstance.L2SiegeFlagInstance(L2SiegeFlagInstance.java:101) Constructor "L2SiegeFlagInstance.L2SiegeFlagInstance(L2PcInstance,int,L2NpcTemplate)" has 0 references  L2SiegeFlagInstance.L2SiegeFlagInstance(L2PcInstance,int,L2NpcTemplate) org.ucdetector.analyzeMarkerReference   com.l2jserver.gameserver.model.actor.instance.L2FortEnvoyInstance.<init>(L2FortEnvoyInstance.java:25)   Class "L2FortEnvoyInstance" has 0 references    L2FortEnvoyInstance org.ucdetector.analyzeMarkerReference   com.l2jserver.gameserver.model.actor.instance.L2PenaltyMonsterInstance.L2PenaltyMonsterInstance(L2PenaltyMonsterInstance.java:29)   Constructor "L2PenaltyMonsterInstance.L2PenaltyMonsterInstance(int,L2NpcTemplate)" has 0 references L2PenaltyMonsterInstance.L2PenaltyMonsterInstance(int,L2NpcTemplate)    org.ucdetector.analyzeMarkerReference   com.l2jserver.gameserver.model.actor.instance.L2VillageMasterFighterInstance.<init>(L2VillageMasterFighterInstance.java:22) Class "L2VillageMasterFighterInstance" has 0 references L2VillageMasterFighterInstance  org.ucdetector.analyzeMarkerReference   com.l2jserver.gameserver.model.actor.instance.L2PetInstance.dropAllItems(L2PetInstance.java:781)    Method "L2PetInstance.dropAllItems()" has 0 references  L2PetInstance.dropAllItems()    org.ucdetector.analyzeMarkerReference   com.l2jserver.gameserver.model.actor.instance.L2PetInstance.updateRefOwner(L2PetInstance.java:1221) Method "L2PetInstance.updateRefOwner(L2PcInstance)" has 0 references    L2PetInstance.updateRefOwner(L2PcInstance)  org.ucdetector.analyzeMarkerReference   com.l2jserver.gameserver.model.actor.instance.L2MercenaryManagerInstance.<init>(L2MercenaryManagerInstance.java:27) Class "L2MercenaryManagerInstance" has 0 references L2MercenaryManagerInstance  org.ucdetector.analyzeMarkerReference   GodKratoscom.l2jserver.gameserver.model.actor.instance.L2ClanTraderInstance.<init>(L2ClanTraderInstance.java:27) Class "L2ClanTraderInstance" has 0 references   L2ClanTraderInstance    org.ucdetector.analyzeMarkerReference   com.l2jserver.gameserver.model.actor.instance.L2FameManagerInstance.<init>(L2FameManagerInstance.java:31)   Class "L2FameManagerInstance" has 0 references  L2FameManagerInstance   org.ucdetector.analyzeMarkerReference   Kerberoscom.l2jserver.gameserver.model.actor.instance.L2FlyTerrainObjectInstance.<init>(L2FlyTerrainObjectInstance.java:21) Class "L2FlyTerrainObjectInstance" has 0 references L2FlyTerrainObjectInstance  org.ucdetector.analyzeMarkerReference   com.l2jserver.gameserver.model.actor.instance.L2ObservationInstance.<init>(L2ObservationInstance.java:25)   Class "L2ObservationInstance" has 0 references  L2ObservationInstance   org.ucdetector.analyzeMarkerReference   NightMarezcom.l2jserver.gameserver.model.actor.instance.L2BoatInstance._logBoat(L2BoatInstance.java:34)   Constant "L2BoatInstance._logBoat" has 0 references L2BoatInstance._logBoat org.ucdetector.analyzeMarkerReference   Maktakien, reworked by DScom.l2jserver.gameserver.model.actor.instance.L2DungeonGatekeeperInstance.<init>(L2DungeonGatekeeperInstance.java:29)   Class "L2DungeonGatekeeperInstance" has 0 references    L2DungeonGatekeeperInstance org.ucdetector.analyzeMarkerReference   com.l2jserver.gameserver.model.actor.instance.L2CastleTeleporterInstance.<init>(L2CastleTeleporterInstance.java:35) Class "L2CastleTeleporterInstance" has 0 references L2CastleTeleporterInstance  org.ucdetector.analyzeMarkerReference   Kerberoscom.l2jserver.gameserver.model.actor.instance.L2VillageMasterMysticInstance.<init>(L2VillageMasterMysticInstance.java:22)   Class "L2VillageMasterMysticInstance" has 0 references  L2VillageMasterMysticInstance   org.ucdetector.analyzeMarkerReference   com.l2jserver.gameserver.model.actor.instance.L2PetManagerInstance.<init>(L2PetManagerInstance.java:28) Class "L2PetManagerInstance" has 0 references   L2PetManagerInstance    org.ucdetector.analyzeMarkerReference   com.l2jserver.gameserver.model.actor.instance.L2ChestInstance.<init>(L2ChestInstance.java:29)   Class "L2ChestInstance" has 0 references    L2ChestInstance org.ucdetector.analyzeMarkerReference   Juliancom.l2jserver.gameserver.model.actor.instance.L2CastleMagicianInstance.<init>(L2CastleMagicianInstance.java:41) Class "L2CastleMagicianInstance" has 0 references   L2CastleMagicianInstance    org.ucdetector.analyzeMarkerReference   Kerberos | ZaKaXcom.l2jserver.gameserver.model.actor.instance.L2CabaleBufferInstance.L2CabaleBufferInstance(L2CabaleBufferInstance.java:191)    Constructor "L2CabaleBufferInstance.L2CabaleBufferInstance(int,L2NpcTemplate)" has 0 references L2CabaleBufferInstance.L2CabaleBufferInstance(int,L2NpcTemplate)    org.ucdetector.analyzeMarkerReference   Layanecom.l2jserver.gameserver.model.actor.instance.L2NpcBufferInstance.<init>(L2NpcBufferInstance.java:39)   Class "L2NpcBufferInstance" has 0 references    L2NpcBufferInstance org.ucdetector.analyzeMarkerReference   com.l2jserver.gameserver.model.actor.instance.L2ArtefactInstance.L2ArtefactInstance(L2ArtefactInstance.java:48) Constructor "L2ArtefactInstance.L2ArtefactInstance(int,L2NpcTemplate)" has 0 references L2ArtefactInstance.L2ArtefactInstance(int,L2NpcTemplate)    org.ucdetector.analyzeMarkerReference   com.l2jserver.gameserver.model.actor.instance.L2TvTEventNpcInstance.<init>(L2TvTEventNpcInstance.java:25)   Class "L2TvTEventNpcInstance" has 0 references  L2TvTEventNpcInstance   org.ucdetector.analyzeMarkerReference   com.l2jserver.gameserver.model.actor.instance.L2MonsterInstance.enableMinions(L2MonsterInstance.java:203)   Method "L2MonsterInstance.enableMinions(boolean)" has 0 references  L2MonsterInstance.enableMinions(boolean)    org.ucdetector.analyzeMarkerReference   com.l2jserver.gameserver.model.actor.instance.L2ControllableMobInstance.L2ControllableMobInstance(L2ControllableMobInstance.java:55)    Constructor "L2ControllableMobInstance.L2ControllableMobInstance(int,L2NpcTemplate)" has 0 references   L2ControllableMobInstance.L2ControllableMobInstance(int,L2NpcTemplate)  org.ucdetector.analyzeMarkerReference   littlecrowcom.l2jserver.gameserver.model.actor.instance.L2TransformManagerInstance.L2TransformManagerInstance(L2TransformManagerInstance.java:56) Constructor "L2TransformManagerInstance.L2TransformManagerInstance(int,L2NpcTemplate)" has 0 references L2TransformManagerInstance.L2TransformManagerInstance(int,L2NpcTemplate)    org.ucdetector.analyzeMarkerReference   Zoey76com.l2jserver.gameserver.model.actor.instance.L2DawnPriestInstance.L2DawnPriestInstance(L2DawnPriestInstance.java:24)   Constructor "L2DawnPriestInstance.L2DawnPriestInstance(int,L2NpcTemplate)" has 0 references L2DawnPriestInstance.L2DawnPriestInstance(int,L2NpcTemplate)    org.ucdetector.analyzeMarkerReference   com.l2jserver.gameserver.model.actor.instance.L2FlyRaidBossInstance.<init>(L2FlyRaidBossInstance.java:19)   Class "L2FlyRaidBossInstance" has 0 references  L2FlyRaidBossInstance   org.ucdetector.analyzeMarkerReference   com.l2jserver.gameserver.model.actor.instance.L2VillageMasterDElfInstance.<init>(L2VillageMasterDElfInstance.java:21)   Class "L2VillageMasterDElfInstance" has 0 references    L2VillageMasterDElfInstance org.ucdetector.analyzeMarkerReference   com.l2jserver.gameserver.model.actor.instance.L2OlympiadManagerInstance.L2OlympiadManagerInstance(L2OlympiadManagerInstance.java:28)    Constructor "L2OlympiadManagerInstance.L2OlympiadManagerInstance(int,L2NpcTemplate)" has 0 references   L2OlympiadManagerInstance.L2OlympiadManagerInstance(int,L2NpcTemplate)  org.ucdetector.analyzeMarkerReference   godsoncom.l2jserver.gameserver.model.actor.instance.L2OlympiadManagerInstance.showChatWindow(L2OlympiadManagerInstance.java:34)   Method "L2OlympiadManagerInstance.showChatWindow(L2PcInstance,int,String)" has 0 references L2OlympiadManagerInstance.showChatWindow(L2PcInstance,int,String)   org.ucdetector.analyzeMarkerReference   godsoncom.l2jserver.gameserver.model.actor.instance.L2FortManagerInstance.<init>(L2FortManagerInstance.java:42)   Class "L2FortManagerInstance" has 0 references  L2FortManagerInstance   org.ucdetector.analyzeMarkerReference   com.l2jserver.gameserver.model.actor.instance.L2BirthdayCakeInstance.L2BirthdayCakeInstance(L2BirthdayCakeInstance.java:37) Constructor "L2BirthdayCakeInstance.L2BirthdayCakeInstance(int,L2NpcTemplate)" has 0 references L2BirthdayCakeInstance.L2BirthdayCakeInstance(int,L2NpcTemplate)    org.ucdetector.analyzeMarkerReference   Nyarancom.l2jserver.gameserver.model.actor.instance.L2BlockInstance.L2BlockInstance(L2BlockInstance.java:43)  Constructor "L2BlockInstance.L2BlockInstance(int,L2NpcTemplate)" has 0 references   L2BlockInstance.L2BlockInstance(int,L2NpcTemplate)  org.ucdetector.analyzeMarkerReference   BiggBosscom.l2jserver.gameserver.model.actor.instance.L2BlockInstance.changeColor(L2BlockInstance.java:55)  Method "L2BlockInstance.changeColor(L2PcInstance,ArenaParticipantsHolder,*)" has 0 references   L2BlockInstance.changeColor(L2PcInstance,ArenaParticipantsHolder,*) org.ucdetector.analyzeMarkerReference   BiggBosscom.l2jserver.gameserver.model.actor.instance.L2FriendlyMobInstance.L2FriendlyMobInstance(L2FriendlyMobInstance.java:31)    Constructor "L2FriendlyMobInstance.L2FriendlyMobInstance(int,L2NpcTemplate)" has 0 references   L2FriendlyMobInstance.L2FriendlyMobInstance(int,L2NpcTemplate)  org.ucdetector.analyzeMarkerReference   com.l2jserver.gameserver.model.actor.instance.L2ClassMasterInstance.L2ClassMasterInstance(L2ClassMasterInstance.java:45)    Constructor "L2ClassMasterInstance.L2ClassMasterInstance(int,L2NpcTemplate)" has 0 references   L2ClassMasterInstance.L2ClassMasterInstance(int,L2NpcTemplate)  org.ucdetector.analyzeMarkerReference   com.l2jserver.gameserver.model.actor.instance.L2RiftInvaderInstance.L2RiftInvaderInstance(L2RiftInvaderInstance.java:22)    Constructor "L2RiftInvaderInstance.L2RiftInvaderInstance(int,L2NpcTemplate)" has 0 references   L2RiftInvaderInstance.L2RiftInvaderInstance(int,L2NpcTemplate)  org.ucdetector.analyzeMarkerReference   com.l2jserver.gameserver.model.actor.instance.L2CastleDoormenInstance.<init>(L2CastleDoormenInstance.java:24)   Class "L2CastleDoormenInstance" has 0 references    L2CastleDoormenInstance org.ucdetector.analyzeMarkerReference   com.l2jserver.gameserver.model.actor.instance.L2ManorManagerInstance.L2ManorManagerInstance(L2ManorManagerInstance.java:22) Constructor "L2ManorManagerInstance.L2ManorManagerInstance(int,L2NpcTemplate)" has 0 references L2ManorManagerInstance.L2ManorManagerInstance(int,L2NpcTemplate)    org.ucdetector.analyzeMarkerReference   com.l2jserver.gameserver.model.actor.instance.L2TrainerHealersInstance.L2TrainerHealersInstance(L2TrainerHealersInstance.java:37)   Constructor "L2TrainerHealersInstance.L2TrainerHealersInstance(int,L2NpcTemplate)" has 0 references L2TrainerHealersInstance.L2TrainerHealersInstance(int,L2NpcTemplate)    org.ucdetector.analyzeMarkerReference   Zoey76com.l2jserver.gameserver.model.actor.instance.L2WeddingManagerInstance.<init>(L2WeddingManagerInstance.java:33) Class "L2WeddingManagerInstance" has 0 references   L2WeddingManagerInstance    org.ucdetector.analyzeMarkerReference   evill33t & squeezedcom.l2jserver.gameserver.model.actor.instance.L2SummonInstance.addExpAndSp(L2SummonInstance.java:220)   Method "L2SummonInstance.addExpAndSp(int,int)" has 0 references L2SummonInstance.addExpAndSp(int,int)   org.ucdetector.analyzeMarkerReference   com.l2jserver.gameserver.model.actor.instance.L2FortSupportCaptainInstance.<init>(L2FortSupportCaptainInstance.java:36) Class "L2FortSupportCaptainInstance" has 0 references   L2FortSupportCaptainInstance    org.ucdetector.analyzeMarkerReference   Vicecom.l2jserver.gameserver.model.actor.instance.L2CastleChamberlainInstance.L2CastleChamberlainInstance(L2CastleChamberlainInstance.java:56)  Constructor "L2CastleChamberlainInstance.L2CastleChamberlainInstance(int,L2NpcTemplate)" has 0 references   L2CastleChamberlainInstance.L2CastleChamberlainInstance(int,L2NpcTemplate)  org.ucdetector.analyzeMarkerReference   com.l2jserver.gameserver.model.actor.instance.L2DoorInstance.log(L2DoorInstance.java:60)    Constant "L2DoorInstance.log" has 0 references  L2DoorInstance.log  org.ucdetector.analyzeMarkerReference   com.l2jserver.gameserver.model.actor.instance.L2DoorInstance.getDistanceToWatchObject(L2DoorInstance.java:460)  Method "L2DoorInstance.getDistanceToWatchObject(L2Object)" has 0 references L2DoorInstance.getDistanceToWatchObject(L2Object)   org.ucdetector.analyzeMarkerReference   com.l2jserver.gameserver.model.actor.instance.L2DoorInstance.getDistanceToForgetObject(L2DoorInstance.java:474) Method "L2DoorInstance.getDistanceToForgetObject(L2Object)" has 0 references    L2DoorInstance.getDistanceToForgetObject(L2Object)  org.ucdetector.analyzeMarkerReference   com.l2jserver.gameserver.model.actor.instance.L2DoorInstance.onOpen(L2DoorInstance.java:537)    Method "L2DoorInstance.onOpen()" has 0 references   L2DoorInstance.onOpen() org.ucdetector.analyzeMarkerReference   com.l2jserver.gameserver.model.actor.instance.L2SepulcherNpcInstance.L2SepulcherNpcInstance(L2SepulcherNpcInstance.java:56) Constructor "L2SepulcherNpcInstance.L2SepulcherNpcInstance(int,L2NpcTemplate)" has 0 references L2SepulcherNpcInstance.L2SepulcherNpcInstance(int,L2NpcTemplate)    org.ucdetector.analyzeMarkerReference   sandmancom.l2jserver.gameserver.model.actor.instance.L2ClanHallManagerInstance.L2ClanHallManagerInstance(L2ClanHallManagerInstance.java:51)    Constructor "L2ClanHallManagerInstance.L2ClanHallManagerInstance(int,L2NpcTemplate)" has 0 references   L2ClanHallManagerInstance.L2ClanHallManagerInstance(int,L2NpcTemplate)  org.ucdetector.analyzeMarkerReference   com.l2jserver.gameserver.model.actor.instance.L2ClanHallManagerInstance.COND_BUSY_BECAUSE_OF_SIEGE(L2ClanHallManagerInstance.java:43)   Constant "L2ClanHallManagerInstance.COND_BUSY_BECAUSE_OF_SIEGE" has 0 references    L2ClanHallManagerInstance.COND_BUSY_BECAUSE_OF_SIEGE    org.ucdetector.analyzeMarkerReference   com.l2jserver.gameserver.model.actor.instance.L2FestivalMonsterInstance.L2FestivalMonsterInstance(L2FestivalMonsterInstance.java:45)    Constructor "L2FestivalMonsterInstance.L2FestivalMonsterInstance(int,L2NpcTemplate)" has 0 references   L2FestivalMonsterInstance.L2FestivalMonsterInstance(int,L2NpcTemplate)  org.ucdetector.analyzeMarkerReference   Tempycom.l2jserver.gameserver.model.actor.instance.L2TownPetInstance.<init>(L2TownPetInstance.java:32)   Class "L2TownPetInstance" has 0 references  L2TownPetInstance   org.ucdetector.analyzeMarkerReference   Kerberoscom.l2jserver.gameserver.model.actor.instance.L2MercManagerInstance.L2MercManagerInstance(L2MercManagerInstance.java:29)    Constructor "L2MercManagerInstance.L2MercManagerInstance(int,L2NpcTemplate)" has 0 references   L2MercManagerInstance.L2MercManagerInstance(int,L2NpcTemplate)  org.ucdetector.analyzeMarkerReference   com.l2jserver.gameserver.model.actor.instance.L2VillageMasterOrcInstance.<init>(L2VillageMasterOrcInstance.java:21) Class "L2VillageMasterOrcInstance" has 0 references L2VillageMasterOrcInstance  org.ucdetector.analyzeMarkerReference   com.l2jserver.gameserver.model.actor.instance.L2EventChestInstance.<init>(L2EventChestInstance.java:14) Class "L2EventChestInstance" has 0 references   L2EventChestInstance    org.ucdetector.analyzeMarkerReference   Gnacikcom.l2jserver.gameserver.model.actor.instance.L2VillageMasterKamaelInstance.<init>(L2VillageMasterKamaelInstance.java:23)   Class "L2VillageMasterKamaelInstance" has 0 references  L2VillageMasterKamaelInstance   org.ucdetector.analyzeMarkerReference   com.l2jserver.gameserver.model.actor.instance.L2TerritoryWardInstance.<init>(L2TerritoryWardInstance.java:30)   Class "L2TerritoryWardInstance" has 0 references    L2TerritoryWardInstance org.ucdetector.analyzeMarkerReference   com.l2jserver.gameserver.model.actor.instance.L2CastleWyvernManagerInstance.<init>(L2CastleWyvernManagerInstance.java:19)   Class "L2CastleWyvernManagerInstance" has 0 references  L2CastleWyvernManagerInstance   org.ucdetector.analyzeMarkerReference   com.l2jserver.gameserver.model.actor.instance.L2FortDoormenInstance.<init>(L2FortDoormenInstance.java:24)   Class "L2FortDoormenInstance" has 0 references  L2FortDoormenInstance   org.ucdetector.analyzeMarkerReference   com.l2jserver.gameserver.model.actor.instance.L2TerrainObjectInstance.<init>(L2TerrainObjectInstance.java:21)   Class "L2TerrainObjectInstance" has 0 references    L2TerrainObjectInstance org.ucdetector.analyzeMarkerReference   com.l2jserver.gameserver.model.actor.instance.L2FortWyvernManagerInstance.<init>(L2FortWyvernManagerInstance.java:19)   Class "L2FortWyvernManagerInstance" has 0 references    L2FortWyvernManagerInstance org.ucdetector.analyzeMarkerReference   com.l2jserver.gameserver.model.actor.instance.L2QuestGuardInstance.<init>(L2QuestGuardInstance.java:28) Class "L2QuestGuardInstance" has 0 references   L2QuestGuardInstance    org.ucdetector.analyzeMarkerReference   GKRcom.l2jserver.gameserver.model.actor.instance.L2ClanHallDoormenInstance.<init>(L2ClanHallDoormenInstance.java:29)   Class "L2ClanHallDoormenInstance" has 0 references  L2ClanHallDoormenInstance   org.ucdetector.analyzeMarkerReference   com.l2jserver.gameserver.model.actor.instance.L2SiegeNpcInstance.<init>(L2SiegeNpcInstance.java:27) Class "L2SiegeNpcInstance" has 0 references L2SiegeNpcInstance  org.ucdetector.analyzeMarkerReference   com.l2jserver.gameserver.model.actor.instance.L2TeleporterInstance.L2TeleporterInstance(L2TeleporterInstance.java:51)   Constructor "L2TeleporterInstance.L2TeleporterInstance(int,L2NpcTemplate)" has 0 references L2TeleporterInstance.L2TeleporterInstance(int,L2NpcTemplate)    org.ucdetector.analyzeMarkerReference   NightMarezcom.l2jserver.gameserver.model.actor.instance.L2DuskPriestInstance.<init>(L2DuskPriestInstance.java:22) Class "L2DuskPriestInstance" has 0 references   L2DuskPriestInstance    org.ucdetector.analyzeMarkerReference   com.l2jserver.gameserver.model.actor.instance.L2AdventurerInstance.<init>(L2AdventurerInstance.java:25) Class "L2AdventurerInstance" has 0 references   L2AdventurerInstance    org.ucdetector.analyzeMarkerReference   LBaldicom.l2jserver.gameserver.model.actor.instance.L2FortBallistaInstance.L2FortBallistaInstance(L2FortBallistaInstance.java:31) Constructor "L2FortBallistaInstance.L2FortBallistaInstance(int,L2NpcTemplate)" has 0 references L2FortBallistaInstance.L2FortBallistaInstance(int,L2NpcTemplate)    org.ucdetector.analyzeMarkerReference   com.l2jserver.gameserver.model.actor.instance.L2VillageMasterPriestInstance.<init>(L2VillageMasterPriestInstance.java:22)   Class "L2VillageMasterPriestInstance" has 0 references  L2VillageMasterPriestInstance   org.ucdetector.analyzeMarkerReference   com.l2jserver.gameserver.model.actor.instance.L2StaticObjectInstance.log(L2StaticObjectInstance.java:37)    Constant "L2StaticObjectInstance.log" has 0 references  L2StaticObjectInstance.log  org.ucdetector.analyzeMarkerReference   com.l2jserver.gameserver.model.actor.instance.L2StaticObjectInstance.<init>(L2StaticObjectInstance.java:48) Member class "L2StaticObjectInstance.AIAccessor" has 0 references   L2StaticObjectInstance.AIAccessor   org.ucdetector.analyzeMarkerReference   com.l2jserver.gameserver.model.actor.instance.L2XmassTreeInstance.L2XmassTreeInstance(L2XmassTreeInstance.java:70)  Constructor "L2XmassTreeInstance.L2XmassTreeInstance(int,L2NpcTemplate)" has 0 references   L2XmassTreeInstance.L2XmassTreeInstance(int,L2NpcTemplate)  org.ucdetector.analyzeMarkerReference   Drunkard Zabb0xcom.l2jserver.gameserver.model.actor.instance.L2TamedBeastInstance.L2TamedBeastInstance(L2TamedBeastInstance.java:65)   Constructor "L2TamedBeastInstance.L2TamedBeastInstance(int,L2NpcTemplate)" has 0 references L2TamedBeastInstance.L2TamedBeastInstance(int,L2NpcTemplate)    org.ucdetector.analyzeMarkerReference   com.l2jserver.gameserver.model.actor.instance.L2TamedBeastInstance.L2TamedBeastInstance(L2TamedBeastInstance.java:72)   Constructor "L2TamedBeastInstance.L2TamedBeastInstance(int,L2NpcTemplate,L2PcInstance,*,*,*,*)" has 0 references    L2TamedBeastInstance.L2TamedBeastInstance(int,L2NpcTemplate,L2PcInstance,*,*,*,*)   org.ucdetector.analyzeMarkerReference   com.l2jserver.gameserver.model.actor.instance.L2TamedBeastInstance.L2TamedBeastInstance(L2TamedBeastInstance.java:85)   Constructor "L2TamedBeastInstance.L2TamedBeastInstance(int,L2NpcTemplate,L2PcInstance,*,*,*,*,*)" has 0 references  L2TamedBeastInstance.L2TamedBeastInstance(int,L2NpcTemplate,L2PcInstance,*,*,*,*,*) org.ucdetector.analyzeMarkerReference   com.l2jserver.gameserver.model.actor.instance.L2TamedBeastInstance.onReceiveFood(L2TamedBeastInstance.java:101) Method "L2TamedBeastInstance.onReceiveFood()" has 0 references  L2TamedBeastInstance.onReceiveFood()    org.ucdetector.analyzeMarkerReference   com.l2jserver.gameserver.model.actor.instance.L2TamedBeastInstance.addBeastSkill(L2TamedBeastInstance.java:189) Method "L2TamedBeastInstance.addBeastSkill(L2Skill)" has 0 references   L2TamedBeastInstance.addBeastSkill(L2Skill) org.ucdetector.analyzeMarkerReference   com.l2jserver.gameserver.model.actor.instance.L2TamedBeastInstance.castBeastSkills(L2TamedBeastInstance.java:196)   Method "L2TamedBeastInstance.castBeastSkills()" has 0 references    L2TamedBeastInstance.castBeastSkills()  org.ucdetector.analyzeMarkerReference   com.l2jserver.gameserver.model.actor.instance.L2AuctioneerInstance.<init>(L2AuctioneerInstance.java:39) Class "L2AuctioneerInstance" has 0 references   L2AuctioneerInstance    org.ucdetector.analyzeMarkerReference   com.l2jserver.gameserver.model.actor.instance.L2FestivalGuideInstance.L2FestivalGuideInstance(L2FestivalGuideInstance.java:44)  Constructor "L2FestivalGuideInstance.L2FestivalGuideInstance(int,L2NpcTemplate)" has 0 references   L2FestivalGuideInstance.L2FestivalGuideInstance(int,L2NpcTemplate)  org.ucdetector.analyzeMarkerReference   Tempycom.l2jserver.gameserver.model.actor.instance.L2FestivalGuideInstance.getStoneCount(L2FestivalGuideInstance.java:151)   Method "L2FestivalGuideInstance.getStoneCount(int)" has 0 references    L2FestivalGuideInstance.getStoneCount(int)  org.ucdetector.analyzeMarkerReference   Tempycom.l2jserver.gameserver.model.actor.instance.L2FestivalGuideInstance.showChatWindow(L2FestivalGuideInstance.java:166)  Method "L2FestivalGuideInstance.showChatWindow(L2PcInstance,int,String,boolean)" has 0 references   L2FestivalGuideInstance.showChatWindow(L2PcInstance,int,String,boolean) org.ucdetector.analyzeMarkerReference   Tempycom.l2jserver.gameserver.model.actor.instance.L2FortSiegeNpcInstance.<init>(L2FortSiegeNpcInstance.java:24) Class "L2FortSiegeNpcInstance" has 0 references L2FortSiegeNpcInstance  org.ucdetector.analyzeMarkerReference   Vicecom.l2jserver.gameserver.model.actor.instance.L2CastleBlacksmithInstance.<init>(L2CastleBlacksmithInstance.java:25) Class "L2CastleBlacksmithInstance" has 0 references L2CastleBlacksmithInstance  org.ucdetector.analyzeMarkerReference   l3xcom.l2jserver.gameserver.model.actor.instance.L2FishermanInstance.L2FishermanInstance(L2FishermanInstance.java:31)  Constructor "L2FishermanInstance.L2FishermanInstance(int,L2NpcTemplate)" has 0 references   L2FishermanInstance.L2FishermanInstance(int,L2NpcTemplate)  org.ucdetector.analyzeMarkerReference   com.l2jserver.gameserver.model.actor.instance.L2CastleWarehouseInstance.<init>(L2CastleWarehouseInstance.java:24)   Class "L2CastleWarehouseInstance" has 0 references  L2CastleWarehouseInstance   org.ucdetector.analyzeMarkerReference   l3xcom.l2jserver.gameserver.model.actor.instance.L2FlyNpcInstance.<init>(L2FlyNpcInstance.java:19) Class "L2FlyNpcInstance" has 0 references   L2FlyNpcInstance    org.ucdetector.analyzeMarkerReference   com.l2jserver.gameserver.model.actor.instance.L2GrandBossInstance.L2GrandBossInstance(L2GrandBossInstance.java:42)  Constructor "L2GrandBossInstance.L2GrandBossInstance(int,L2NpcTemplate)" has 0 references   L2GrandBossInstance.L2GrandBossInstance(int,L2NpcTemplate)  org.ucdetector.analyzeMarkerReference   com.l2jserver.gameserver.model.actor.instance.L2SiegeSummonInstance.HOG_CANNON_ID(L2SiegeSummonInstance.java:24)    Constant "L2SiegeSummonInstance.HOG_CANNON_ID" has 0 references L2SiegeSummonInstance.HOG_CANNON_ID org.ucdetector.analyzeMarkerReference   com.l2jserver.gameserver.model.actor.instance.L2SepulcherMonsterInstance.L2SepulcherMonsterInstance(L2SepulcherMonsterInstance.java:42) Constructor "L2SepulcherMonsterInstance.L2SepulcherMonsterInstance(int,L2NpcTemplate)" has 0 references L2SepulcherMonsterInstance.L2SepulcherMonsterInstance(int,L2NpcTemplate)    org.ucdetector.analyzeMarkerReference   sandmancom.l2jserver.gameserver.model.actor.instance.L2FortLogisticsInstance.<init>(L2FortLogisticsInstance.java:28)   Class "L2FortLogisticsInstance" has 0 references    L2FortLogisticsInstance org.ucdetector.analyzeMarkerReference   Vicecom.l2jserver.gameserver.model.actor.instance.L2TotemInstance.L2TotemInstance(L2TotemInstance.java:69)  Constructor "L2TotemInstance.L2TotemInstance(int,L2NpcTemplate)" has 0 references   L2TotemInstance.L2TotemInstance(int,L2NpcTemplate)  org.ucdetector.analyzeMarkerReference   UnAfraidcom.l2jserver.gameserver.model.actor.instance.L2TotemInstance.L2TotemInstance(L2TotemInstance.java:75)  Constructor "L2TotemInstance.L2TotemInstance(int,L2NpcTemplate,int)" has 0 references   L2TotemInstance.L2TotemInstance(int,L2NpcTemplate,int)  org.ucdetector.analyzeMarkerReference   UnAfraidcom.l2jserver.gameserver.model.actor.instance.L2SymbolMakerInstance.<init>(L2SymbolMakerInstance.java:21)   Class "L2SymbolMakerInstance" has 0 references  L2SymbolMakerInstance   org.ucdetector.analyzeMarkerReference   com.l2jserver.gameserver.model.actor.instance.L2RaceManagerInstance.L2RaceManagerInstance(L2RaceManagerInstance.java:68)    Constructor "L2RaceManagerInstance.L2RaceManagerInstance(int,L2NpcTemplate)" has 0 references   L2RaceManagerInstance.L2RaceManagerInstance(int,L2NpcTemplate)  org.ucdetector.analyzeMarkerReference   com.l2jserver.gameserver.model.actor.instance.L2RaceManagerInstance.LANES(L2RaceManagerInstance.java:42)    Constant "L2RaceManagerInstance.LANES" has 0 references L2RaceManagerInstance.LANES org.ucdetector.analyzeMarkerReference   com.l2jserver.gameserver.model.actor.instance.L2RaceManagerInstance.WINDOW_START(L2RaceManagerInstance.java:43) Constant "L2RaceManagerInstance.WINDOW_START" has 0 references  L2RaceManagerInstance.WINDOW_START  org.ucdetector.analyzeMarkerReference   com.l2jserver.gameserver.model.actor.instance.L2RaceManagerInstance.Race(L2RaceManagerInstance.java:444)    Constructor "L2RaceManagerInstance.Race.Race(Info[])" has 0 references  L2RaceManagerInstance.Race.Race(Info[]) org.ucdetector.analyzeMarkerReference   com.l2jserver.gameserver.model.actor.instance.L2RaceManagerInstance.getLaneInfo(L2RaceManagerInstance.java:449) Method "L2RaceManagerInstance.Race.getLaneInfo(int)" has 0 references   L2RaceManagerInstance.Race.getLaneInfo(int) org.ucdetector.analyzeMarkerReference   com.l2jserver.gameserver.model.actor.instance.L2RaceManagerInstance.Info(L2RaceManagerInstance.java:461)    Constructor "L2RaceManagerInstance.Race.Info.Info(int,int,int,int)" has 0 references    L2RaceManagerInstance.Race.Info.Info(int,int,int,int)   org.ucdetector.analyzeMarkerReference   com.l2jserver.gameserver.model.actor.instance.L2FortCommanderInstance.L2FortCommanderInstance(L2FortCommanderInstance.java:38)  Constructor "L2FortCommanderInstance.L2FortCommanderInstance(int,L2NpcTemplate)" has 0 references   L2FortCommanderInstance.L2FortCommanderInstance(int,L2NpcTemplate)  org.ucdetector.analyzeMarkerReference   

[theone]

And here are the results for the classes in the /skills package:

Code: Select all

com.l2jserver.gameserver.skills.conditions.ConditionTargetNone.<init>(ConditionTargetNone.java:24)  Class "ConditionTargetNone" has 0 references    ConditionTargetNone org.ucdetector.analyzeMarkerReference   mkizubcom.l2jserver.gameserver.skills.conditions.ConditionSlotItemType.<init>(ConditionSlotItemType.java:27)  Class "ConditionSlotItemType" has 0 references  ConditionSlotItemType   org.ucdetector.analyzeMarkerReference   mkizubcom.l2jserver.gameserver.skills.conditions.ConditionPlayerBaseStats.<init>(ConditionPlayerBaseStats.java:26)    Class "ConditionPlayerBaseStats" has 0 references   ConditionPlayerBaseStats    org.ucdetector.analyzeMarkerReference   mkizubcom.l2jserver.gameserver.skills.conditions.ConditionTargetBodyPart.<init>(ConditionTargetBodyPart.java:27)  Class "ConditionTargetBodyPart" has 0 references    ConditionTargetBodyPart org.ucdetector.analyzeMarkerReference   mkizubcom.l2jserver.gameserver.skills.conditions.ConditionPlayerGrade._log(ConditionPlayerGrade.java:28)  Constant "ConditionPlayerGrade._log" has 0 references   ConditionPlayerGrade._log   org.ucdetector.analyzeMarkerReference   Gigiikuncom.l2jserver.gameserver.skills.conditions.ConditionPlayerGrade.COND_NO_GRADE(ConditionPlayerGrade.java:30) Constant "ConditionPlayerGrade.COND_NO_GRADE" has 0 references  ConditionPlayerGrade.COND_NO_GRADE  org.ucdetector.analyzeMarkerReference   Gigiikuncom.l2jserver.gameserver.skills.conditions.ConditionPlayerGrade.COND_D_GRADE(ConditionPlayerGrade.java:31)  Constant "ConditionPlayerGrade.COND_D_GRADE" has 0 references   ConditionPlayerGrade.COND_D_GRADE   org.ucdetector.analyzeMarkerReference   Gigiikuncom.l2jserver.gameserver.skills.conditions.ConditionPlayerGrade.COND_C_GRADE(ConditionPlayerGrade.java:32)  Constant "ConditionPlayerGrade.COND_C_GRADE" has 0 references   ConditionPlayerGrade.COND_C_GRADE   org.ucdetector.analyzeMarkerReference   Gigiikuncom.l2jserver.gameserver.skills.conditions.ConditionPlayerGrade.COND_B_GRADE(ConditionPlayerGrade.java:33)  Constant "ConditionPlayerGrade.COND_B_GRADE" has 0 references   ConditionPlayerGrade.COND_B_GRADE   org.ucdetector.analyzeMarkerReference   Gigiikuncom.l2jserver.gameserver.skills.conditions.ConditionPlayerGrade.COND_A_GRADE(ConditionPlayerGrade.java:34)  Constant "ConditionPlayerGrade.COND_A_GRADE" has 0 references   ConditionPlayerGrade.COND_A_GRADE   org.ucdetector.analyzeMarkerReference   Gigiikuncom.l2jserver.gameserver.skills.conditions.ConditionPlayerGrade.COND_S_GRADE(ConditionPlayerGrade.java:35)  Constant "ConditionPlayerGrade.COND_S_GRADE" has 0 references   ConditionPlayerGrade.COND_S_GRADE   org.ucdetector.analyzeMarkerReference   Gigiikuncom.l2jserver.gameserver.skills.conditions.ConditionPlayerGrade.COND_S80_GRADE(ConditionPlayerGrade.java:36)    Constant "ConditionPlayerGrade.COND_S80_GRADE" has 0 references ConditionPlayerGrade.COND_S80_GRADE org.ucdetector.analyzeMarkerReference   Gigiikuncom.l2jserver.gameserver.skills.conditions.ConditionPlayerGrade.COND_S84_GRADE(ConditionPlayerGrade.java:37)    Constant "ConditionPlayerGrade.COND_S84_GRADE" has 0 references ConditionPlayerGrade.COND_S84_GRADE org.ucdetector.analyzeMarkerReference   Gigiikuncom.l2jserver.gameserver.skills.conditions.ConditionItemId.<init>(ConditionItemId.java:24)  Class "ConditionItemId" has 0 references    ConditionItemId org.ucdetector.analyzeMarkerReference   mkizubcom.l2jserver.gameserver.skills.funcs.FuncEnchantHp.<init>(FuncEnchantHp.java:26)   Class "FuncEnchantHp" has 0 references  FuncEnchantHp   org.ucdetector.analyzeMarkerReference   Yamanekocom.l2jserver.gameserver.skills.funcs.FuncEnchant.<init>(FuncEnchant.java:25)   Class "FuncEnchant" has 0 references    FuncEnchant org.ucdetector.analyzeMarkerReference   com.l2jserver.gameserver.skills.funcs.FuncDiv.<init>(FuncDiv.java:22)   Class "FuncDiv" has 0 references    FuncDiv org.ucdetector.analyzeMarkerReference   com.l2jserver.gameserver.skills.funcs.FuncBaseMul.<init>(FuncBaseMul.java:22)   Class "FuncBaseMul" has 0 references    FuncBaseMul org.ucdetector.analyzeMarkerReference   com.l2jserver.gameserver.skills.funcs.LambdaRnd.<init>(LambdaRnd.java:23)   Class "LambdaRnd" has 0 references  LambdaRnd   org.ucdetector.analyzeMarkerReference   mkizubcom.l2jserver.gameserver.skills.funcs.FuncSet.<init>(FuncSet.java:22)   Class "FuncSet" has 0 references    FuncSet org.ucdetector.analyzeMarkerReference   com.l2jserver.gameserver.skills.funcs.FuncMul.<init>(FuncMul.java:22)   Class "FuncMul" has 0 references    FuncMul org.ucdetector.analyzeMarkerReference   com.l2jserver.gameserver.skills.funcs.FuncSub.<init>(FuncSub.java:22)   Class "FuncSub" has 0 references    FuncSub org.ucdetector.analyzeMarkerReference   com.l2jserver.gameserver.skills.l2skills.L2SkillSiegeFlag.L2SkillSiegeFlag(L2SkillSiegeFlag.java:44)    Constructor "L2SkillSiegeFlag.L2SkillSiegeFlag(StatsSet)" has 0 references  L2SkillSiegeFlag.L2SkillSiegeFlag(StatsSet) org.ucdetector.analyzeMarkerReference   com.l2jserver.gameserver.skills.l2skills.L2SkillChangeWeapon.L2SkillChangeWeapon(L2SkillChangeWeapon.java:40)   Constructor "L2SkillChangeWeapon.L2SkillChangeWeapon(StatsSet)" has 0 references    L2SkillChangeWeapon.L2SkillChangeWeapon(StatsSet)   org.ucdetector.analyzeMarkerReference   nBdcom.l2jserver.gameserver.skills.l2skills.L2SkillLearnSkill.L2SkillLearnSkill(L2SkillLearnSkill.java:29) Constructor "L2SkillLearnSkill.L2SkillLearnSkill(StatsSet)" has 0 references    L2SkillLearnSkill.L2SkillLearnSkill(StatsSet)   org.ucdetector.analyzeMarkerReference   com.l2jserver.gameserver.skills.l2skills.L2SkillDefault.L2SkillDefault(L2SkillDefault.java:25)  Constructor "L2SkillDefault.L2SkillDefault(StatsSet)" has 0 references  L2SkillDefault.L2SkillDefault(StatsSet) org.ucdetector.analyzeMarkerReference   com.l2jserver.gameserver.skills.l2skills.L2SkillSummon.checkCondition(L2SkillSummon.java:94)    Method "L2SkillSummon.checkCondition(L2Character)" has 0 references L2SkillSummon.checkCondition(L2Character)   org.ucdetector.analyzeMarkerReference   com.l2jserver.gameserver.skills.l2skills.L2SkillChargeDmg.L2SkillChargeDmg(L2SkillChargeDmg.java:41)    Constructor "L2SkillChargeDmg.L2SkillChargeDmg(StatsSet)" has 0 references  L2SkillChargeDmg.L2SkillChargeDmg(StatsSet) org.ucdetector.analyzeMarkerReference   com.l2jserver.gameserver.skills.l2skills.L2SkillSweeper.L2SkillSweeper(L2SkillSweeper.java:33)  Constructor "L2SkillSweeper.L2SkillSweeper(StatsSet)" has 0 references  L2SkillSweeper.L2SkillSweeper(StatsSet) org.ucdetector.analyzeMarkerReference   JIVcom.l2jserver.gameserver.skills.l2skills.L2SkillElemental.<init>(L2SkillElemental.java:28)  Class "L2SkillElemental" has 0 references   L2SkillElemental    org.ucdetector.analyzeMarkerReference   com.l2jserver.gameserver.skills.l2skills.L2SkillCreateItem.L2SkillCreateItem(L2SkillCreateItem.java:39) Constructor "L2SkillCreateItem.L2SkillCreateItem(StatsSet)" has 0 references    L2SkillCreateItem.L2SkillCreateItem(StatsSet)   org.ucdetector.analyzeMarkerReference   Nemesisscom.l2jserver.gameserver.skills.l2skills.L2SkillMount.L2SkillMount(L2SkillMount.java:30)    Constructor "L2SkillMount.L2SkillMount(StatsSet)" has 0 references  L2SkillMount.L2SkillMount(StatsSet) org.ucdetector.analyzeMarkerReference   com.l2jserver.gameserver.skills.l2skills.L2SkillTrap.L2SkillTrap(L2SkillTrap.java:41)   Constructor "L2SkillTrap.L2SkillTrap(StatsSet)" has 0 references    L2SkillTrap.L2SkillTrap(StatsSet)   org.ucdetector.analyzeMarkerReference   com.l2jserver.gameserver.skills.l2skills.L2SkillTrap._trapSpawn(L2SkillTrap.java:35)    Field "L2SkillTrap._trapSpawn" has 0 references L2SkillTrap._trapSpawn  org.ucdetector.analyzeMarkerReference   com.l2jserver.gameserver.skills.l2skills.L2SkillAppearance.L2SkillAppearance(L2SkillAppearance.java:32) Constructor "L2SkillAppearance.L2SkillAppearance(StatsSet)" has 0 references    L2SkillAppearance.L2SkillAppearance(StatsSet)   org.ucdetector.analyzeMarkerReference   com.l2jserver.gameserver.skills.l2skills.L2SkillSignet.L2SkillSignet(L2SkillSignet.java:39) Constructor "L2SkillSignet.L2SkillSignet(StatsSet)" has 0 references    L2SkillSignet.L2SkillSignet(StatsSet)   org.ucdetector.analyzeMarkerReference   com.l2jserver.gameserver.skills.l2skills.L2SkillSignet.effectId(L2SkillSignet.java:37)  Field "L2SkillSignet.effectId" is never read    L2SkillSignet.effectId  org.ucdetector.analyzeMarkerReference   com.l2jserver.gameserver.skills.l2skills.L2SkillAgathion.L2SkillAgathion(L2SkillAgathion.java:28)   Constructor "L2SkillAgathion.L2SkillAgathion(StatsSet)" has 0 references    L2SkillAgathion.L2SkillAgathion(StatsSet)   org.ucdetector.analyzeMarkerReference   com.l2jserver.gameserver.skills.l2skills.L2SkillDecoy.L2SkillDecoy(L2SkillDecoy.java:32)    Constructor "L2SkillDecoy.L2SkillDecoy(StatsSet)" has 0 references  L2SkillDecoy.L2SkillDecoy(StatsSet) org.ucdetector.analyzeMarkerReference   com.l2jserver.gameserver.skills.l2skills.L2SkillTeleport.L2SkillTeleport(L2SkillTeleport.java:37)   Constructor "L2SkillTeleport.L2SkillTeleport(StatsSet)" has 0 references    L2SkillTeleport.L2SkillTeleport(StatsSet)   org.ucdetector.analyzeMarkerReference   com.l2jserver.gameserver.skills.l2skills.L2SkillDrain.L2SkillDrain(L2SkillDrain.java:46)    Constructor "L2SkillDrain.L2SkillDrain(StatsSet)" has 0 references  L2SkillDrain.L2SkillDrain(StatsSet) org.ucdetector.analyzeMarkerReference   com.l2jserver.gameserver.skills.l2skills.L2SkillSpawn.L2SkillSpawn(L2SkillSpawn.java:44)    Constructor "L2SkillSpawn.L2SkillSpawn(StatsSet)" has 0 references  L2SkillSpawn.L2SkillSpawn(StatsSet) org.ucdetector.analyzeMarkerReference   Zoey76com.l2jserver.gameserver.skills.l2skills.L2SkillSignetCasttime.L2SkillSignetCasttime(L2SkillSignetCasttime.java:32) Constructor "L2SkillSignetCasttime.L2SkillSignetCasttime(StatsSet)" has 0 references    L2SkillSignetCasttime.L2SkillSignetCasttime(StatsSet)   org.ucdetector.analyzeMarkerReference   com.l2jserver.gameserver.skills.l2skills.L2SkillSignetCasttime._effectNpcId(L2SkillSignetCasttime.java:29)  Field "L2SkillSignetCasttime._effectNpcId" is never read    L2SkillSignetCasttime._effectNpcId  org.ucdetector.analyzeMarkerReference   com.l2jserver.gameserver.skills.l2skills.L2SkillSignetCasttime.effectId(L2SkillSignetCasttime.java:30)  Field "L2SkillSignetCasttime.effectId" is never read    L2SkillSignetCasttime.effectId  org.ucdetector.analyzeMarkerReference   com.l2jserver.gameserver.skills.BaseStats.valueOfXml(BaseStats.java:77) Method "BaseStats.valueOfXml(String)" has 0 references  BaseStats.valueOfXml(String)    org.ucdetector.analyzeMarkerReference   DScom.l2jserver.gameserver.skills.Formulas.<init>(Formulas.java:91)   Member class "Formulas.FuncAddLevel3" has 0 references  Formulas.FuncAddLevel3  org.ucdetector.analyzeMarkerReference   com.l2jserver.gameserver.skills.Formulas.<init>(Formulas.java:114)  Member class "Formulas.FuncMultLevelMod" has 0 references   Formulas.FuncMultLevelMod   org.ucdetector.analyzeMarkerReference   com.l2jserver.gameserver.skills.Formulas.<init>(Formulas.java:137)  Member class "Formulas.FuncMultRegenResting" has 0 references   Formulas.FuncMultRegenResting   org.ucdetector.analyzeMarkerReference   com.l2jserver.gameserver.skills.Formulas.calcBlowDamage(Formulas.java:1372) Method "Formulas.calcBlowDamage(L2Character,L2Character,L2Skill,*,*)" has 0 references  Formulas.calcBlowDamage(L2Character,L2Character,L2Skill,*,*)    org.ucdetector.analyzeMarkerReference   com.l2jserver.gameserver.skills.Formulas.calcBlow(Formulas.java:1969)   Method "Formulas.calcBlow(L2Character,L2Character,int)" has 0 references    Formulas.calcBlow(L2Character,L2Character,int)  org.ucdetector.analyzeMarkerReference   com.l2jserver.gameserver.skills.Formulas.calcLethalHit(Formulas.java:2014)  Method "Formulas.calcLethalHit(L2Character,L2Character,L2Skill)" has 0 references   Formulas.calcLethalHit(L2Character,L2Character,L2Skill) org.ucdetector.analyzeMarkerReference   com.l2jserver.gameserver.skills.Formulas.__calcHitMiss(Formulas.java:2166)  Method "Formulas.__calcHitMiss(L2Character,L2Character)" has 0 references   Formulas.__calcHitMiss(L2Character,L2Character) org.ucdetector.analyzeMarkerReference   com.l2jserver.gameserver.skills.Formulas.calcMagicAffected(Formulas.java:2298)  Method "Formulas.calcMagicAffected(L2Character,L2Character,L2Skill)" has 0 references   Formulas.calcMagicAffected(L2Character,L2Character,L2Skill) org.ucdetector.analyzeMarkerReference   com.l2jserver.gameserver.skills.Formulas.calcManaDam(Formulas.java:2905)    Method "Formulas.calcManaDam(L2Character,L2Character,L2Skill,*,*)" has 0 references Formulas.calcManaDam(L2Character,L2Character,L2Skill,*,*)   org.ucdetector.analyzeMarkerReference   com.l2jserver.gameserver.skills.Formulas.calcBlowSuccess(Formulas.java:3173)    Method "Formulas.calcBlowSuccess(L2Character,L2Character,L2Skill)" has 0 references Formulas.calcBlowSuccess(L2Character,L2Character,L2Skill)   org.ucdetector.analyzeMarkerReference   com.l2jserver.gameserver.skills.Env.effect(Env.java:33) Field "Env.effect" has 0 references Env.effect  org.ucdetector.analyzeMarkerReference   

[tukune]

com.l2jserver.gameserver.model.actor.instance.L2VillageMasterDwarfInstance.<init>(L2VillageMasterDwarfInstance.java:21) Class "L2VillageMasterDwarfInstance" has 0 references L2VillageMasterDwarfInstance org.ucdetector.analyzeMarkerReference

in npc.sql
(30498,30498,'Moke',0,'Warehouse Chief',0,'LineageNPC.e_warehouse_master_MDwarf','8','17.5',70,'male','L2VillageMasterDwarf',40,'2444.46819','1345.8','7.5','2.7',40,43,30,21,20,20,0,0,'688.86373','295.91597','470.40463','216.53847',253,4,333,0,0,0,50,120,0,1),

you must learn java

[theone]

in npc.sql
(30498,30498,'Moke',0,'Warehouse Chief',0,'LineageNPC.e_warehouse_master_MDwarf','8','17.5',70,'male','L2VillageMasterDwarf',40,'2444.46819','1345.8','7.5','2.7',40,43,30,21,20,20,0,0,'688.86373','295.91597','470.40463','216.53847',253,4,333,0,0,0,50,120,0,1),

you must learn java

keep in mind that some of those methods/constants/fields are perhaps used in the datapack, so removing them should be done carefully!

You must learn to read

Also, these objects are created in the core and there's no reference to L2VillageMasterDwarfInstance in the core(not a single one, I just re-checked). Have you at least taken a minute to look at how they're instantiated before you made that post? And if you're going to give me java lessons, I'm listening, please do! I'm curious to see that!

[ir00]

Nice, but will it will get committed ?

[Zoey76]

Nice, but will it will get committed ?

At the moment there is nothing to commit here, this is a suggestion and we'll take it in consideration, but like tukune pointed out we use reflection for many things like npcs, skills and items so many classes at core aren't called untill datapack is loaded.

[theone]

Nice, but will it will get committed ?

This will need to be done differently as Zoey pointed out.
The datapack needs to be cross-referenced while running the dead/duplicate code finder.
At the moment I'm a bit stuck on other projects, I'll look into that and report on my findings when I'm done with the 2 other projects I've started.

[afk5min]

The last time I've checked (a few years ago), all npcs were created like this:

Get the template by NPC ID from the NpcTable (which, in turn, preloads templates from the npc table).
Get next object ID.
Take the 'type' from the template, append 'Instance', do a blind shot with reflection (not that there are many options here) at the [...]model.instance package, hoping there is a class with that name and a suitable constructor.

That's why L2VillageMasterDwarfInstance is "not used" in core. There are no cast/instanceof operations done, but that class is far from useless.

About "unused" methods:
You need to reference .py files from the datapack as well, otherwise the results will be incorrect and something will break (usual scenario).
You can generate class files from jython scripts; however, reflection is used for everything, so that may or may not help you.

[theone]

That's exactly what we're saying
When I did the first check for dead code I totally overlooked the dp stuff. Dont pay attention to the results atm, I'll post new results later on when I get a chance.