Festival of Darkness

[Belier]

If you want to receive support we need this info to help you properly.
» Find Revision
L2J Revision Number:4691
L2JDP Revision Number:8089

I have a big error in festival of darkness: The points of each cabal is displaying all wrong.

I add images self-explained:





Thank you and waiting any solution

[kocinski]

This Event is historically buged since ever and needs a big rework.
Has been reported lot of times but so far has not been corrected.

[Belier]

How can I suspend it then?

Thank you

[Belier]

then, no solution?

I just need to desactivate the festival of darkness =)

Thanks!

[Sdw]

Code: Select all

Index: SevenSignsFestival.java===================================================================--- SevenSignsFestival.java (revision 4692)+++ SevenSignsFestival.java (working copy)@@ -1586,7 +1586,7 @@        {            // If the current score is greater than that for the other cabal,            // then they already have the points from this festival.-           if (thisCabalHighScore < otherCabalHighScore)+           if (thisCabalHighScore > otherCabalHighScore)                return false;                        List<Integer> prevParticipants = getPreviousParticipants(oracle, festivalId); 

Should fix the score registration.

[Belier]

Testing!

I will tell later if this works

[kostantinos]

so?

[kostantinos]

Code: Select all

Index: SevenSignsFestival.java===================================================================--- SevenSignsFestival.java (revision 4692)+++ SevenSignsFestival.java (working copy)@@ -1586,7 +1586,7 @@        {            // If the current score is greater than that for the other cabal,            // then they already have the points from this festival.-           if (thisCabalHighScore < otherCabalHighScore)+           if (thisCabalHighScore > otherCabalHighScore)                return false;                        List<Integer> prevParticipants = getPreviousParticipants(oracle, festivalId); 

Should fix the score registration.

if you ahve test pliz tell me yes or no

[Sdw]

Try it yourself, there is no big deal in this modification, it won't ruin anything, just plain logic. The worst that can happen is that it still doesn't work.

[Faelucc]

Hi,
I tested this fix long time ago and it worked.

BUT, I don't recommend to enable festivals: it still a lot of bugs.

[galrunch]

this modification to fix this problem is in DP l2j server o core l2j server?

[Faelucc]

L2J_Server/java/com/l2jserver/gameserver/SevenSignsFestival.java

[galrunch]

oks, is a core l2j server thx

[galrunch]

mmm, i'm was trying this fix but in my serveer don't work :S anyone can tell me another method to fix this bug of seven sings?

[Faelucc]

Sorry for posting here, but this problem still exist on revision 5247.

The solution given above works, I've tested it several times.

But, for the reason I said in ticket 4887, I prefer to delete this four lines...

Code: Select all

Index: java/com/l2jserver/gameserver/SevenSignsFestival.java===================================================================--- java/com/l2jserver/gameserver/SevenSignsFestival.java   (revision 5247)+++ java/com/l2jserver/gameserver/SevenSignsFestival.java   (working copy)@@ -1569,11 +1569,6 @@        // Check if this is the highest score for this level range so far for the player's cabal.        if (offeringScore > thisCabalHighScore)        {-           // If the current score is greater than that for the other cabal,-           // then they already have the points from this festival.-           if (thisCabalHighScore < otherCabalHighScore)-               return false;-                       List<Integer> prevParticipants = getPreviousParticipants(oracle, festivalId);            partyMembers = new ArrayList<String>(prevParticipants.size());