[URGENT]: All Skills from sub-class in the base-class

[lucan]

If you want to receive support we need this info to help you properly.
» Find Revision
L2J Revision Number: 4685
L2JDP Revision Number: 8075

You can add all skills from all sub-class to base-class using some bug.
How to repeat:
Go to the output of a city with a sub-class, eg: Goddard, attract some Mob back in to the any class master, kill the mob and quickly take your base-class, are the skills base with the skills of the sub and it does not go.
The char take all skills form all subs in base-classe if repeat this in all subs.
Note: I not tested whether you can do the same bug from one sub to another sub, i test only from sub to base class.
Sugestion: Do not allow to switch sub-classes in combat mode, if someone has please post urgent patch.

How can I remove all the wrong skill-based character that came from a sub-class?

The following configuration would remove the skills of the subs in base if char login?
# Check players for non-allowed skills
# Default: False
SkillCheckEnable = True

# If true, remove invalid skills from player and database.
# Report only, if false.
# Default: False
SkillCheckRemove = True

[Zoey76]

Same issue reported here: Ticket #5240

[lucan]

Exactly! But this ticket was opened seven months ago? Has not been resolved yet?
Thanks!

[Zeldak]

i think that is something with multi-thread problem.

[lucan]

Another means of bug ...
Cancel or get a new sub-class, attck and attract a mob to an NPC Master Class, with the sub-calss kill the monster and quickly switch to your base class. In High Rate servers the player will rise from lvl 40 to lvl 50 or 55, quickly changing to the base class all the sub skills of the new lvl 40 to 55 will be recorded in the Base Class.

[lucan]

I solved the problem by not allowing the player to add, remove or change any sub-class in combat mode because it is the moment that the bug occurs, the player kill the monster and can quickly change to base-class from the sub-class.
I do not know if it's a very elegant solution but it solved my problem! I am sharing the code, if someone has something better please let us know.
Thanks!!!!!

Code: Select all

Index: L2VillageMasterInstance.java===================================================================--- L2VillageMasterInstance.java    (revision 4681)+++ L2VillageMasterInstance.java    (working copy)@@ -354,6 +354,12 @@                        _log.warning("Player "+player.getName()+" has performed a subclass change too fast");                        return;                    }++                   if (player.isInCombat())+                   {+                       _log.warning("Player "+player.getName()+" has performed a subclass change in combat mode");+                       return;+                   }                                        boolean allowAddition = true;                    @@ -416,6 +422,12 @@                        _log.warning("Player "+player.getName()+" has performed a subclass change too fast");                        return;                    }++                   if (player.isInCombat())+                   {+                       _log.warning("Player "+player.getName()+" has performed a subclass change in combat mode");+                       return;+                   }                                        if (player.getClassIndex() == paramOne)                    {@@ -449,6 +461,12 @@                    // validity check                    if (paramOne < 1 || paramOne > Config.MAX_SUBCLASS)                        return;++                   if (player.isInCombat())+                   {+                       _log.warning("Player "+player.getName()+" has performed a subclass change in combat mode");+                       return;+                   }                                        subsAvailable = getAvailableSubClasses(player);                    @@ -502,6 +520,12 @@                        _log.warning("Player "+player.getName()+" has performed a subclass change too fast");                        return;                    }++                   if (player.isInCombat())+                   {+                       _log.warning("Player "+player.getName()+" has performed a subclass change in combat mode");+                       return;+                   }                                        if (!isValidNewSubClass(player, paramTwo))                        return; 

[Starter]

This has already been discussed here in this thread: viewtopic.php?f=77&t=21315&hilit=multiskill#p120959 and in several other threads I think.

The only thing you further more need to add is a restriction that you cannot change your subclass while being in a party where your party members are in combat but thats not that hard isnt it?

[lucan]

I apologize because I was searching the forum another way and did not find your post.
Your code is more sense, thank you and sorry for anything!
Can close the topic.