No success/fail info

[babun]

If you want to receive support we need this info to help you properly.
» Find Revision
L2J Revision Number:4425
L2JDP Revision Number:7669
Hi,
first of all i want to 10x to l2j devs for the job that they are doing.
My problem is that when character use any kind of debuff skill there is no info about success or fail of used skill.
I mean there is no way to know did your atack(debuf) is landed or no(only way is to see animation: stars when stun is successfull). If some one can help me it will be gread.

I dont think it is bug that is why i post here. May be is a little think but...

[Edelvez]

It is client side problem.. change the system

[jurchiks]

no it's not, it's calculated serverside, client only shows the appropriate animation.

[babun]

no it's not, it's calculated serverside, client only shows the appropriate animation.

yes show anymation and effect is done (when skill success) but no sign at all about success or fail.

[jurchiks]

data/scripts/handlers/skillhandlers/Disablers.java:

Code: Select all

case ROOT:                case DISARM:                case STUN:                {                    if (Formulas.calcSkillReflect(target, skill) == Formulas.SKILL_REFLECT_SUCCEED)                        target = activeChar;                                        if (Formulas.calcSkillSuccess(activeChar, target, skill, shld, ss, sps, bss))                        skill.getEffects(activeChar, target, new Env(shld, ss, sps, bss));                    else                    {                        if (activeChar instanceof L2PcInstance)                        {                            SystemMessage sm = new SystemMessage(SystemMessageId.C1_RESISTED_YOUR_S2);                            sm.addCharName(target);                            sm.addSkillName(skill);                            activeChar.sendPacket(sm);                        }                    }                    break;                }

As you can see, if the skill is resisted, a system message is sent to the player. It's pretty much the same for all debuffs.
But I can't find a success message anywhere...

[babun]

Can be easily made with success msg coz for me is a little bit not good to have message only for fail. Can be made a massage % for success landing skill/debuff?

P.S. i am not sure did i have to make other topic for % success landing skill/debuff, if have to pls tell i will made.

[jurchiks]

well, it should work like this:

Code: Select all

if (Formulas.calcSkillSuccess(activeChar, target, skill, shld, ss, sps, bss))                    {                        skill.getEffects(activeChar, target, new Env(shld, ss, sps, bss));                        SystemMessage sm = new SystemMessage(SystemMessageId.S1_SUCCEEDED);                        sm.addSkillName(skill);                        activeChar.sendPacket(sm);                    }                    else if (activeChar instanceof L2PcInstance)                    {                        SystemMessage sm = new SystemMessage(SystemMessageId.C1_RESISTED_YOUR_S2);                        sm.addCharName(target);                        sm.addSkillName(skill);                        activeChar.sendPacket(sm);                    } 

Edit: dunno what you mean by that % success...

[Natla]

hummm maybe he wants a colored system?

[Edelvez]

hummm maybe he wants a colored system?

Client side

[babun]

Edit: dunno what you mean by that % success...

I have seen that on some russion servers. There is shown your chance of landing skill/debuff.
I cant remember exactly but there is writen something like this:
You use stun
Stun chance 95%
Stun failed

[jurchiks]

meh, I won't bother with that.

[_DS_]

Use .debug voice command (enabled in l2jmods) or //debug admin command. Require some knowledge.