Inheritance? L2Character?

This is not a Support area! Discuss about the Server here. Non-Server related discussion goes in Off-Topic Discussion.
Forum rules
READ NOW: L2j Forums Rules of Conduct
Post Reply
Phantom2005
Posts: 72
Joined: Wed Jul 06, 2005 4:27 pm
Location: Netherlands

Inheritance? L2Character?

Post by Phantom2005 »

Please take a good look at the inheritance of some actors..
Atm L2Character is a mess inheritance-wise if you ask me.

I'll just give one of the many examples..
So if someone is bored @ l2j team he could do it.

Or just add me on msn and I'll help :mrgreen:

Code: Select all

     //L2Character    public void setIsRunning(boolean value)    {        _isRunning = value;        if (getRunSpeed() != 0)            broadcastPacket(new ChangeMoveType(this));    }     // L2PcInstance    public final void setIsRunning(boolean value)    {        super.setIsRunning(value);        this.broadcastUserInfo();    }     // L2Summon    public final void setIsRunning(boolean value)    {        super.setIsRunning(value);        this.broadcastStatusUpdate();    }     // L2Npc    public final void setIsRunning(boolean value)    {        super.setIsRunning(value);        Collection<L2PcInstance> plrs = getKnownList().getKnownPlayers().values();        //synchronized (character.getKnownList().getKnownPlayers())        {            for (L2PcInstance player : plrs)            {                if (player == null)                    continue;                                if (getRunSpeed() == 0)                    player.sendPacket(new ServerObjectInfo((L2Npc) this, player));                else                    player.sendPacket(new AbstractNpcInfo.NpcInfo((L2Npc) this, player));            }        }    } 
"If 64 bits isn't enough, the next logical step is 128 bits. That's enough to survive Moore's Law until I'm dead, and after that, it's not my problem."
©Jeff Bonwick
hope
Posts: 1160
Joined: Thu Aug 30, 2007 5:17 pm

Re: Inheritance? L2Character?

Post by hope »

Just write a fixed patch and upload
Phantom2005
Posts: 72
Joined: Wed Jul 06, 2005 4:27 pm
Location: Netherlands

Re: Inheritance? L2Character?

Post by Phantom2005 »

I doubt it will match with the upcoming new Freya files.
"If 64 bits isn't enough, the next logical step is 128 bits. That's enough to survive Moore's Law until I'm dead, and after that, it's not my problem."
©Jeff Bonwick
hope
Posts: 1160
Joined: Thu Aug 30, 2007 5:17 pm

Re: Inheritance? L2Character?

Post by hope »

Then wait for new files and see if they need many work
_DS_
L2j Veteran
L2j Veteran
Posts: 3437
Joined: Wed Apr 30, 2008 8:53 am
Location: Russia

Re: Inheritance? L2Character?

Post by _DS_ »

Peoples on forum always cry about features, features and features. So you will get only features. Things like this did only on dev's inspirations and if we have enough time.
Commiter of the shit
public static final int PI = 3.1415926535897932384626433832795;
User avatar
Zoey76
L2j Inner Circle
L2j Inner Circle
Posts: 7005
Joined: Tue Aug 11, 2009 3:36 am

Re: Inheritance? L2Character?

Post by Zoey76 »

Powered by Eclipse 4.30 🌌 | Eclipse Temurin 21 ☕ | MariaDB 11.3.2 🗃️ | L2J Server 2.6.3.0 - High Five 🚀

🔗 Join our Discord! 🎮💬
User avatar
Szponiasty
Advanced User
Advanced User
Posts: 557
Joined: Mon Apr 21, 2008 1:31 pm
Location: Eastern Poland

Re: Inheritance? L2Character?

Post by Szponiasty »

Yeah. Similar with eg isAttackingNow(), that for everything returns true if char is during attack (hit), and for summons/pets it returns isInCombat (stance) :)
And in the next chronicle they went into space, fighting the evil empire... In a galaxy far, far away xD
gmexid
Posts: 33
Joined: Fri Mar 01, 2013 10:09 pm

Re: Inheritance? L2Character?

Post by gmexid »

seems to be working correctly now
Post Reply