You have no idea how bugged this pack is...
Posted: Tue Aug 18, 2015 9:09 pm
So I started my server and I must say that in less than 12 hours found dozens of pack related bugs.
I won't even bother talking or reporting or sharing fixes for anything until god Zoey will change his attitude towards sharers instantly and dramatically.
But just a small (a very small) taste:
EnlargeAbnormalSlot is bugged, when you learn divine inspiration you need to get +1 slot, but instead you get +x slot depending on divine inspiration level, for example for divine insp level 4 you get:
Which is:
23 (more because previous levels are bugged too) + 4 (should be +1) = 27 slots. (players can get up to 30 buff slots with this bug, considering the config BUFFS_MAX_AMOUNT is set to 20)
Note that current formula is correct IF character relogs as 20 + 4 = 24 as it should be.
Solution: change the above line to:
Needs to be changed on onExit() aswell.
OR, if you fear that divine insp is not the only skill going to use this handler, you have no choice but to change getMaxBuffCount() to return maxBuffSlots + divineInspLevel, and make divine insp not use this handler anymore.
I'm most annoyed when it comes to super simple and basic gameplay stuff like this being bugged, yet zoey works on loggers and project refactors, bravo...
I won't even bother talking or reporting or sharing fixes for anything until god Zoey will change his attitude towards sharers instantly and dramatically.
But just a small (a very small) taste:
EnlargeAbnormalSlot is bugged, when you learn divine inspiration you need to get +1 slot, but instead you get +x slot depending on divine inspiration level, for example for divine insp level 4 you get:
Code: Select all
info.getEffected().getStat().setMaxBuffCount(info.getEffected().getStat().getMaxBuffCount() + _slots);
23 (more because previous levels are bugged too) + 4 (should be +1) = 27 slots. (players can get up to 30 buff slots with this bug, considering the config BUFFS_MAX_AMOUNT is set to 20)
Note that current formula is correct IF character relogs as 20 + 4 = 24 as it should be.
Solution: change the above line to:
Code: Select all
info.getEffected().getStat().setMaxBuffCount(Config.BUFFS_MAX_AMOUNT + _slots);
OR, if you fear that divine insp is not the only skill going to use this handler, you have no choice but to change getMaxBuffCount() to return maxBuffSlots + divineInspLevel, and make divine insp not use this handler anymore.
I'm most annoyed when it comes to super simple and basic gameplay stuff like this being bugged, yet zoey works on loggers and project refactors, bravo...