L2J Server

Saw this posted on aCis:
https://github.com/brettwooldridge/HikariCP
Seems like a serious project, in active development, good documentation... Worth a try IMHO.

Interesting

The benchmark seems amazing, but will it really make any notable difference?

Well i have tested it some months ago it had some bugs so we decided c3p0 is better for now maybe if project matures a bit we can switch.

C3p0 is active and I know some of the developers, it's not bleeding edge tech, but it's very robust, we could make core to accept different pool managers

Well, aside from the bugs in HikariCP (what kind of bugs anyway? maybe they're really minor?), c3p0 can't compare in performance. If we don't use it, adding support for it would be good for those who want to experiment, and for possible future switch.

jurchiks wrote:Well, aside from the bugs in HikariCP (what kind of bugs anyway? maybe they're really minor?), c3p0 can't compare in performance. If we don't use it, adding support for it would be good for those who want to experiment, and for possible future switch.

It had poor error reporting some SQL exceptions were getting hidden(related to connection and retry) also some configs were not doing what they were described to or were half working.

Nos wrote:also some configs were not doing what they were described to or were half working.

So like L2j

Aaand that is terrible because? Sounds like minor issues that can be fixed in a jiffy. Contributing config renames is easy, that should be accepted pretty quickly. The error reporting thing also shouldn't be a problem if you can argumentate your reasoning properly.

Zoey76 wrote:

Nos wrote:also some configs were not doing what they were described to or were half working.

So like L2j

especially drop ones

can anyone make diff patch to test HikariCp ?

Not sure if better, but as promised https://github.com/L2J/L2J_Server/tree/ ... ionFactory

I like those graphs which every project have almost same just as main actor is their project. Anyway those projects looks nice in testing phase and on live with lot of ppl starting real fun.

St3eT wrote:I like those graphs which every project have almost same just as main actor is their project. Anyway those projects looks nice in testing phase and on live with lot of ppl starting real fun.

Sdw, UnAfraid and you said the same, I guess you didn't used it properly, since I used it on an application that get hit by 500 transactions per second all of them with database access and it performed well after proper configuration.