Page 1 of 1
How do I force the Silence to doesn't blocks the scrolls?
Posted: Wed May 30, 2012 4:35 pm
by Arantir
Physical silence blocks the Scroll of Escape & Scroll of Resurrection. How can I change it?
I try to add "ignoreSkillMute" with value "true" to 2013/2014 skills, but there was no effect!
If I add "isPotion" to this skills Silence no more blocks the scrolls, but appeared some bugs (because scroll is not a potion, yes?). Also if add "isMagic" to skill, physical silence doesn't block it, but magic silence does. But why does "ignoreSkillMute" not work? I want that any type of silence could not block the scrolls.
Re: How do I force the Silence to doesn't blocks the scrolls
Posted: Wed May 30, 2012 4:53 pm
by MELERIX
Arantir wrote:Physical silence blocks the Scroll of Escape & Scroll of Resurrection. How can I change it?
I try to add "ignoreSkillMute" with value "true" to 2013/2014 skills, but there was no effect!
If I add "isPotion" to this skills Silence no more blocks the scrolls, but appeared some bugs (because scroll is not a potion, yes?). Also if add "isMagic" to skill, physical silence doesn't block it, but magic silence does. But why does "ignoreSkillMute" not work? I want that any type of silence could not block the scrolls.
it will be fixed later probably, atm Adry_85 is reworking isMagic system from skills.
Re: How do I force the Silence to doesn't blocks the scrolls
Posted: Wed May 30, 2012 5:12 pm
by Arantir
MELERIX wrote:it will be fixed later probably, atm Adry_85 is reworking isMagic system from skills.
"isMagic" works fine as I noticed =) The problem is in "ignoreSkillMute" =(
Interesting thing is that "<some L2Skill variable for id 2013>.ignoreSkillMute()" really returns "true" if it is set in xml, but in some reason silence (mute) still blocks this skill.
Re: How do I force the Silence to doesn't blocks the scrolls
Posted: Wed May 30, 2012 5:15 pm
by MELERIX
isMagic is incomplete in L2J, you will understand later why is related with ignoreSkillMute and probably it will fix the bug
Re: How do I force the Silence to doesn't blocks the scrolls
Posted: Wed May 30, 2012 5:50 pm
by Arantir
I think I have found this bug!
com.l2jserver.gameserver.model.actor.L2Character.checkDoCastConditions(), line:
if (!skill.isPotion() || !skill.ignoreSkillMute())
{
// block skill if char is mute ...
// ...
It must be:
if (!skill.isPotion() && !skill.ignoreSkillMute)
Another way this condition returns false only if skill "isPotion" and "ignoreSkillMute" at the same time!
Example for SOE with "ignoreSkillMute":
(!false || !true) == (true || false) == true, so script continue and see that char.isMute() of isPhisicalMute() and blocks skill!
but:
(!false && !true) == (true && false) == false -> skill is not blocked! =)
Also potions still don't blocked:
(!true && !false) == (false && true) == false
P.S.: There are more that one line like in the first quote inside the core...
Re: How do I force the Silence to doesn't blocks the scrolls
Posted: Wed May 30, 2012 6:32 pm
by Zoey76
That was changed because there was other problem.
In my opiniuon ignore mute skill is wrong.
Re: How do I force the Silence to doesn't blocks the scrolls
Posted: Wed May 30, 2012 10:09 pm
by Arantir
Zoey76 wrote:That was changed because there was other problem.
H-m-m-m... What the problem, may I ask?
Zoey76 wrote:In my opiniuon ignore mute skill is wrong.
It was my own choice to make scrolls non-blocked by silence, (players are tired of retail =))
Problem have become in the way to reach this feature, specific in "ignoreSkillMute"...