Page 1 of 1
Festival of Darkness
Posted: Mon Jun 27, 2011 3:41 am
by Belier
If you want to receive support we need this info to help you properly.
» Find Revision
L2J Revision
Number:4691
L2JDP Revision
Number:8089
I have a big error in festival of darkness: The points of each cabal is displaying all wrong.
I add images self-explained:
Thank you and waiting any solution
Re: Festival of Darkness
Posted: Mon Jun 27, 2011 7:57 am
by kocinski
This Event is historically buged since ever and needs a big rework.
Has been reported lot of times but so far has not been corrected.
Re: Festival of Darkness
Posted: Mon Jun 27, 2011 1:59 pm
by Belier
How can I suspend it then?
Thank you
Re: Festival of Darkness
Posted: Fri Jul 01, 2011 1:49 pm
by Belier
then, no solution?
I just need to desactivate the festival of darkness =)
Thanks!
Re: Festival of Darkness
Posted: Sat Jul 02, 2011 8:25 pm
by Sdw
Code: Select all
Index: SevenSignsFestival.java===================================================================--- SevenSignsFestival.java (revision 4692)+++ SevenSignsFestival.java (working copy)@@ -1586,7 +1586,7 @@ { // If the current score is greater than that for the other cabal, // then they already have the points from this festival.- if (thisCabalHighScore < otherCabalHighScore)+ if (thisCabalHighScore > otherCabalHighScore) return false; List<Integer> prevParticipants = getPreviousParticipants(oracle, festivalId);
Should fix the score registration.
Re: Festival of Darkness
Posted: Fri Jul 08, 2011 2:54 pm
by Belier
Testing!
I will tell later if this works
Re: Festival of Darkness
Posted: Mon Jul 18, 2011 3:00 pm
by kostantinos
so?
Re: Festival of Darkness
Posted: Mon Jul 18, 2011 5:06 pm
by kostantinos
Sdw wrote:Code: Select all
Index: SevenSignsFestival.java===================================================================--- SevenSignsFestival.java (revision 4692)+++ SevenSignsFestival.java (working copy)@@ -1586,7 +1586,7 @@ { // If the current score is greater than that for the other cabal, // then they already have the points from this festival.- if (thisCabalHighScore < otherCabalHighScore)+ if (thisCabalHighScore > otherCabalHighScore) return false; List<Integer> prevParticipants = getPreviousParticipants(oracle, festivalId);
Should fix the score registration.
if you ahve test pliz tell me yes or no
Re: Festival of Darkness
Posted: Mon Jul 18, 2011 5:40 pm
by Sdw
Try it yourself, there is no big deal in this modification, it won't ruin anything, just plain logic. The worst that can happen is that it still doesn't work.
Re: Festival of Darkness
Posted: Tue Jul 19, 2011 12:17 pm
by Faelucc
Hi,
I tested this fix long time ago and it worked.
BUT, I don't recommend to enable festivals: it still a lot of bugs.
Re: Festival of Darkness
Posted: Sun Aug 21, 2011 10:22 pm
by galrunch
this modification to fix this problem is in DP l2j server o core l2j server?
Re: Festival of Darkness
Posted: Mon Aug 22, 2011 12:51 pm
by Faelucc
L2J_Server/java/com/l2jserver/gameserver/SevenSignsFestival.java
Re: Festival of Darkness
Posted: Mon Aug 22, 2011 2:30 pm
by galrunch
oks, is a core l2j server thx
Re: Festival of Darkness
Posted: Fri Aug 26, 2011 1:05 am
by galrunch
mmm, i'm was trying this fix but in my serveer don't work :S anyone can tell me another method to fix this bug of seven sings?
Re: Festival of Darkness
Posted: Mon Apr 02, 2012 5:17 pm
by Faelucc
Sorry for posting here, but this problem still exist on revision 5247.
The solution given above works, I've tested it several times.
But, for the reason I said in
ticket 4887, I prefer to delete this four lines...
Code: Select all
Index: java/com/l2jserver/gameserver/SevenSignsFestival.java===================================================================--- java/com/l2jserver/gameserver/SevenSignsFestival.java (revision 5247)+++ java/com/l2jserver/gameserver/SevenSignsFestival.java (working copy)@@ -1569,11 +1569,6 @@ // Check if this is the highest score for this level range so far for the player's cabal. if (offeringScore > thisCabalHighScore) {- // If the current score is greater than that for the other cabal,- // then they already have the points from this festival.- if (thisCabalHighScore < otherCabalHighScore)- return false;- List<Integer> prevParticipants = getPreviousParticipants(oracle, festivalId); partyMembers = new ArrayList<String>(prevParticipants.size());