Page 1 of 2

SkillCheckRemove Issue

Posted: Mon Oct 04, 2010 7:23 pm
by Starter
Is it only me or is the new feature (since Freya) removing the transferred skills which healer can achieve since eqilogue with holy pomander as well?

Im asking because im currently using the latest epi version with the needed code parts for the new feature and its removing the skills mentioned above too. :S

Re: SkillCheckRemove Issue

Posted: Mon Oct 04, 2010 8:13 pm
by MELERIX
better use Freya, Epilogue is not supported now.

Re: SkillCheckRemove Issue

Posted: Mon Oct 04, 2010 8:16 pm
by JIV
disable skill remove.

Re: SkillCheckRemove Issue

Posted: Mon Oct 04, 2010 9:17 pm
by _DS_
Worksforme. You fail to update tables properly. And not, you cant just take one little code fragment and use on different package, skill checker is quite complexive, in both core, datapack and data files.

Re: SkillCheckRemove Issue

Posted: Tue Oct 05, 2010 2:17 pm
by Starter
_DS_ wrote:Worksforme. You fail to update tables properly. And not, you cant just take one little code fragment and use on different package, skill checker is quite complexive, in both core, datapack and data files.
Yes I can. :mrgreen:

I think I didnt miss anyting core-side and datapack-side (skills and the one (?) modification of the skill transfer script) neither so I dont know where the problem could be. And data? Isnt datapack == data? :roll:

With tables you mean that you changed something in the database as well? I should take a closer look there then.^^

Re: SkillCheckRemove Issue

Posted: Tue Oct 05, 2010 2:19 pm
by _DS_
skill_trees

Re: SkillCheckRemove Issue

Posted: Tue Oct 05, 2010 2:22 pm
by Starter
_DS_ wrote:skill_trees
Thx! :D

Ah btw maybe I missed those skills but as said before im pretty sure that I didnt miss anything datapack-side so can you check if the aurabird skills and the master ability - defense skill are all excluded from the check as well (because they got removed from the players as well..)? (Cant check it myself atm from work because of the file view thingy and I cant download the whole source^^)

Re: SkillCheckRemove Issue

Posted: Tue Oct 05, 2010 2:48 pm
by _DS_
All subclass certification skills are excluded from main check.

Also, if applied non-properly, you possibly allow you players to learn forgotten scroll skills by specially crafted packet.

Re: SkillCheckRemove Issue

Posted: Tue Oct 05, 2010 7:23 pm
by Starter
Ok after checking the skill_trees table I see now that its better to just take the freya version - its way better then the epilogue version anyway - great work btw! :wink:

Re: SkillCheckRemove Issue

Posted: Sat Oct 09, 2010 5:41 pm
by Starter
Okay the freya version is running fine but now there is the issue that skills learned through forgotten scrolls are removed somehow (at least I saw that curse of desparion got removed from a soultaker after logging in back again). Any idea?

Re: SkillCheckRemove Issue

Posted: Sat Oct 09, 2010 6:03 pm
by _DS_
This is easy: in default l2j datapack skill 1541 "Curse of Desparion" marked as not done.
If you make this skill by yourself - its your task to add it into skill_trees.

Anyway, i added it to the next release.

Re: SkillCheckRemove Issue

Posted: Sat Oct 09, 2010 7:05 pm
by Starter
_DS_ wrote:This is easy: in default l2j datapack skill 1541 "Curse of Desparion" marked as not done.
If you make this skill by yourself - its your task to add it into skill_trees.

Anyway, i added it to the next release.
Thank you! :)

Re: SkillCheckRemove Issue

Posted: Sat Oct 09, 2010 8:51 pm
by MELERIX
Starter wrote:Okay the freya version is running fine but now there is the issue that skills learned through forgotten scrolls are removed somehow (at least I saw that curse of desparion got removed from a soultaker after logging in back again). Any idea?
is normal because that skill is not used in game yet (may be will be added to game in High Five or future L2 chornicles), same happens with skill Dual Blow, so don't use these skills plz.

Re: SkillCheckRemove Issue

Posted: Sun Oct 10, 2010 1:20 pm
by Starter
MELERIX wrote:
Starter wrote:Okay the freya version is running fine but now there is the issue that skills learned through forgotten scrolls are removed somehow (at least I saw that curse of desparion got removed from a soultaker after logging in back again). Any idea?
is normal because that skill is not used in game yet (may be will be added to game in High Five or future L2 chornicles), same happens with skill Dual Blow, so don't use these skills plz.
But isnt Dual Blow available in Freya already? I mean all other new skills are present except this one..?

Re: SkillCheckRemove Issue

Posted: Sun Oct 10, 2010 1:24 pm
by jurchiks
I had Elf Wind Rider on PTS and I don't remember having Dual Blow...
All forgotten scrolls were in pts helper shop (at least I think it was all of them)