Page 1 of 1

Pvp weapons augmentation help...

Posted: Sun Oct 18, 2009 11:27 am
by rockkth
If you want to receive support we need this info to help you properly.
» Find Revision
L2J Revision Number: latest oct 17 2009
L2JDP Revision Number: latest oct 17 2009


hey,
i was trying to make augmentation possible on pvp weapons, as i used to, the problem is the RequestConfirmTargetItem.java was changed...

the way an item is checked to see if it s pvp or not was probably changed since before these lines were included...(bolded once missing in current gameserver update).

so, how can i make pvp weapons to be augmentable... i looked into all of the modified gameserver files related, buy i just cant see...

Thank you.

Code: Select all

 	if (item.isAugmented())		{			activeChar.sendPacket(new SystemMessage(SystemMessageId.ONCE_AN_ITEM_IS_AUGMENTED_IT_CANNOT_BE_AUGMENTED_AGAIN));			return;		}	[b]	//TODO: can do better? : currently: using isdestroyable() as a check for hero / cursed weapons		else if (itemGrade < L2Item.CRYSTAL_C || itemType != L2Item.TYPE2_WEAPON || !item.isDestroyable() ||				item.isShadowItem() || item.isTimeLimitedItem())		{[/b]			activeChar.sendPacket(new SystemMessage(SystemMessageId.THIS_IS_NOT_A_SUITABLE_ITEM));			return;		}

the only thing different wa in abstractrefinepacket.java but i dont know if removing the pvp condition would allow pvp weaps to be augmented...

Code: Select all

 * Check both player and source item conditions for augmentation process	 */	protected static final boolean isValid(L2PcInstance player, L2ItemInstance item)	{		if (!isValid(player))			return false; 		// Item must belong to owner		if (item.getOwnerId() != player.getObjectId())			return false;		if (item.isAugmented())			return false;		if (item.isHeroItem())			return false;		if (item.isShadowItem())			return false;		if (item.isCommonItem())			return false;		if (item.isEtcItem())			return false;		if (item.isTimeLimitedItem())			return false;		if (item.isWear())			return false;		if (item.isPvp())			return false;		if (item.getItem().getCrystalType() < L2Item.CRYSTAL_C)			return false; 		// Source item can be equipped or in inventory		switch (item.getLocation())		{			case INVENTORY:			case PAPERDOLL:				break;			default:				return false;		} 
so, anybody with some knowledge could help?

PS: i also checked other files, but since i don t know what exactly was changed in them to not allow pvp weaps to be augmented, i m searching a needle in the dark...
abstractenchantpacket
requestrefine
requestconfirmrefineritem
requestconfirmtargetitem
abstractrefinepacket
requestconfirmcancelitem
requestconfirmrefineritem
requestrefine
requestrefinecancel

Re: Pvp weapons augmentation help...

Posted: Sun Oct 18, 2009 12:02 pm
by devo
if you post your question once, its enough.

just remove

Code: Select all

if (item.isPvp()) return false;

Re: Pvp weapons augmentation help...

Posted: Sun Oct 18, 2009 10:32 pm
by rockkth
ty very much, sorry for posting too many times. much appreciated.