Page 1 of 1

AbstractNpcInfo.java

Posted: Wed Apr 22, 2009 10:16 am
by InShadow
» Find Revision
L2J Revision Number: 2938
L2JDP Revision Number: 5983

I am just curious, why we need another parameter "L2Character attacker" in AbstractNpcInfo constructor, since this parameter is not used anywhere in this super class.

Code: Select all

     public AbstractNpcInfo(L2Character cha, L2Character attacker)    {        _isSummoned = cha.isShowSummonAnimation();        _x = cha.getX();        _y = cha.getY();        _z = cha.getZ();        _heading = cha.getHeading();        _mAtkSpd = cha.getMAtkSpd();        _pAtkSpd = cha.getPAtkSpd();        _runSpd = cha.getTemplate().baseRunSpd;        _walkSpd = cha.getTemplate().baseWalkSpd;        _swimRunSpd = _flRunSpd = _flyRunSpd = _runSpd;        _swimWalkSpd = _flWalkSpd = _flyWalkSpd = _walkSpd;    } 
Would be probably nicer to remove it. :)

Re: AbstractNpcInfo.java

Posted: Wed Apr 22, 2009 11:32 am
by DrHouse
Thanks, you are right. I have commited it plus a little fix I have detected after checking it again