Did you replace the whole passage with my version? Because it works fine for me. oONaonah wrote:I tried this and got syntax error, lol. Only this construction I wrote as last works
Anyway it is the same, you also closed 2 times the same connectionStarter wrote:
Did you replace the whole passage with my version? Because it works fine for me. oO
Huh? Maybe im a too bloody newbie at python but imo the openend connection is only 1 time closed (as needed) and only if an exception happens then another try to close the connection happens again. (at least this way its done at several more parts in the script when it comes to "prepareStatement")Naonah wrote:Anyway it is the same, you also closed 2 times the same connectionStarter wrote:
Did you replace the whole passage with my version? Because it works fine for me. oO
Code: Select all
try : ins.executeUpdate() finally : ins.close() L2Databasefactory.close(con)The master solution?! Thx.Stake wrote:Why close a connection twice? It's enough for once.Code: Select all
try : ins.executeUpdate() finally : ins.close() L2Databasefactory.close(con)
Code: Select all
try : ins.executeUpdate() finally : ins.close() L2Databasefactory.close(con)Never put close functions in try clause, always put them in finally, because you know, try only runs until exception is thrown, so if ins.close() throws an exception, L2Databasefactory.close() will not execute. But this way, all should work well.Naonah wrote:You cant use "finally" in Python.Code: Select all
try : ins.executeUpdate() finally : ins.close() L2Databasefactory.close(con)
oops, sryjaniii wrote:yes, you can use finally in python:
http://docs.python.org/tutorial/errors. ... up-actions
but I had syntax error when used "finally" Thank you for your help. I just wrote this cuz after applying your codes I got syntax error (with "finally"). Anyway using your solution I fixed thisStake wrote: Never put close functions in try clause, always put them in finally, because you know, try only runs until exception is thrown, so if ins.close() throws an exception, L2Databasefactory.close() will not execute. But this way, all should work well.
Code: Select all
if event == "delete" : con=L2DatabaseFactory.getInstance().getConnection() rem=con.prepareStatement("DELETE FROM buffer_scheme_list WHERE id=? LIMIT 1") rem.setString(1, eventParam1) try : rem.executeUpdate() except : pass rem=con.prepareStatement("DELETE FROM buffer_scheme_contents WHERE scheme_id=?") rem.setString(1, eventParam1) try : rem.executeUpdate() rem.close() except : pass finally : L2DatabaseFactory.close(con) return rebuildMainHtml(st)Code: Select all
Traceback (innermost last): (no code object) at line 0SyntaxError: ('invalid syntax', ('__init__.py', 734, 25, '\t\t\tfinally : L2DatabaseFactory.close(con)'))Changed in version 2.5: In previous versions of Python, try...except...finally did not work. try...except had to be nested in try...finally.
Code: Select all
try : try : ins.executeUpdate() except : pass # unnecessary, but needed if you want to handle an exceptionfinally : ins.close() L2Databasefactory.close(con)Code: Select all
try : ins.executeUpdate()finally : try : L2Databasefactory.close(con) except : pass