Magic Critical Hits

XavierElf · Post by **XavierElf** » Mon Nov 02, 2009 12:40 am

L2J Revision Number: 3679
L2JDP Revision Number: 6768
It seems, buffs that increase crit chance of the magic does not work.
E.g.,
1) I check my current m. crit rate, it equals 8%.
2) I buff Wild Magic on myself and check m. crit rate. It equals 8% again.
3) I buff Siren's Song ob myself and check m. crit rate. It equals 8% again.

Seems that character m. crit rate based only on WIT...

Probe · Post by **Probe** » Mon Nov 02, 2009 10:16 am

did you limit m.crit on server through configs?

XavierElf · Post by **XavierElf** » Mon Nov 02, 2009 4:04 pm

Of course not. Try to calc m. crit rate youself.
This method:
[java]activeChar.getMCriticalHit(null, null)[/java]
This method always return value influenced by WIT and not influenced by buffs.

Probe · Post by **Probe** » Mon Nov 02, 2009 4:37 pm

Code: Select all

public final int getMCriticalHit(L2Character target, L2Skill skill)	{		if (_activeChar == null)			return 1; 		double mrate = calcStat(Stats.MCRITICAL_RATE, _activeChar.getTemplate().baseMCritRate, target, skill);		if(mrate > Config.MAX_MCRIT_RATE)			mrate = Config.MAX_MCRIT_RATE;		return (int) mrate;	}

seems to me like its using mcrit value and not just WIT...

XavierElf · Post by **XavierElf** » Mon Nov 02, 2009 4:41 pm

Formula seems correct, but calculation still broken...

XavierElf · Post by **XavierElf** » Tue Nov 03, 2009 2:46 pm

The problem still relevant...

Post by **Charus** » Thu Nov 05, 2009 2:09 am

pls test without any buff. with and without valakas neck.

XavierElf · Post by **XavierElf** » Thu Nov 05, 2009 4:33 am

Tested. In all states the value of the m. crit rate one and the same.

XavierElf · Post by **XavierElf** » Thu Nov 05, 2009 4:50 am

Maybe someone else check this?
I use this code for testing:
[java] NumberFormat df = NumberFormat.getNumberInstance(Locale.ENGLISH);df.setMaximumFractionDigits(2);df.setMinimumFractionDigits(0);StringBuilder dialog = new StringBuilder("<html><body>");dialog.append("MСrit rate: ").append(df.format(activeChar.getMCriticalHit(null, null) / 10)).append("%");dialog.append("</body></html>");NpcHtmlMessage html = new NpcHtmlMessage(5);html.setHtml(dialog.toString());activeChar.sendPacket(html); [/java]

XavierElf · Post by **XavierElf** » Wed Nov 11, 2009 8:57 pm

So, anybody else tested it?

L2J Server

Magic Critical Hits

Magic Critical Hits

Re: Magic Critical Hits

Re: Magic Critical Hits

Re: Magic Critical Hits

Re: Magic Critical Hits

Re: Magic Critical Hits

Re: Magic Critical Hits

Re: Magic Critical Hits

Re: Magic Critical Hits

Re: Magic Critical Hits