Weapon SA issues

[Blotch]

datapack version 4995

Here is my problem:

I am dev on a very small server. My current project is fixing missing weapon sa's for a major update. During my work I noticed that ALOT of weapons, mostly dual swords, that have worked for the longest time now don't work. What I have gathered thru searches is L2J is going to a different SA structure (combining same sa with different levels into one skill). Why in the world would someone remove sa's from weapons without making the updated skill work first?? Having to download OLD datapacks to fix old weapons seems a bit counterintuitive. What is going on?? This is making a simple 2 hour project take days of research to find all the busted SA's.

Here is a good example:

Raid sword*raid sword old code: (from hellbound datapack)

<item id='2599' name="raid_sword*raid_sword">
<for>
<set val='190' order='0x08' stat='pAtk'/>
<set val='83' order='0x08' stat='mAtk'/>
<set val='8' order='0x08' stat='rCrit'/>
<add val='0' order='0x10' stat='accCombat'/>
<set val='325' order='0x08' stat='pAtkSpd'/>
<mul val='1.04' order='0x30' stat='pAtkSpd'>
<and>
<using slotitem="2599;16;4"/>
</and>
</mul>
<enchant val='0' order='0x0C' stat='pAtk'/>
<enchant val='0' order='0x0C' stat='mAtk'/>
</for>
</item>

This datapacks code:

<item id="2599" name="Raid Sword*Raid Sword">
<for>
<set val="190" order="0x08" stat="pAtk"/>
<set val="83" order="0x08" stat="mAtk"/>
<set val="8" order="0x08" stat="rCrit"/>
<add val="0" order="0x10" stat="accCombat"/>
<set val="325" order="0x08" stat="pAtkSpd"/>
<enchant val="0" order="0x0C" stat="pAtk"/>
<enchant val="0" order="0x0C" stat="mAtk"/>
</for>
</item>

Sql database shows no skill linked to this item...is there some miscommunication occuring between people?

[toastgodsupreme]

Weapon SAs are currently fucked.

Waiting on DrLecter to get back from where ever he may be so I can submit my current rework. I think I'll try to finish the last few this weekend (only have backblow, empower, magic power, and one or two others left).

[MELERIX]

datapack version 4995

revision 4995 is too old... we don't give support for older l2j chronicles, please update to latest revisions and try again.

[Blotch]

my bad...i meant datapack 6493. that is only a couple days old...still has the issue i mentioned. in fact i am looking at the dual sword sa's right now and i can tell you none of em work. still doesn't answer my question as to why someone would pull the sa off a weapon without finishing the updated method first.

[MELERIX]

Duals Swords SA Bonus at +4 are already done.

Code: Select all

(2599,'Raid Sword*Raid Sword','lrhand','true',2250,3,3,'fine_steel','c',190,10,'dual',8,0.00000,0,0,0,325,0,83,-1,-1,6130000,1885,'true','true','true','true',3045,2,0,0,0,0,0,0,0,'0-0;'), 

Your SQL tables are updated ?

[toastgodsupreme]

my bad...i meant datapack 6493. that is only a couple days old...still has the issue i mentioned. in fact i am looking at the dual sword sa's right now and i can tell you none of em work. still doesn't answer my question as to why someone would pull the sa off a weapon without finishing the updated method first.

LOL!

Welcome to my world. I asked very similar questions when I first started working on weapon SAs. "Why are some of these done properly and others are half assed and others are just dirty hacks?"

No response from anyone. So I'll just let you in on the conclusion I came to... Certain people who will remain nameless, were lazy and didn't feel that it had to be done retail-like. Of course, this creates a clusterfuck when new weapons get added and whatnot.

I'm almost done... the ones I have left are:

Fix Infinity SAs
Magic Weakness
Blessed Body
Magic Chaos
Magic Focus
Magic Shield
Updown
Magic Damage

And the reason I have Infinity SAs on my todo list is because despite what C4 data says, they've changed in how they operate. Regardless of what Melerix wants to believe, we have videos from retail heroes showing that they function differently now (they can be resisted and they do NOT activate on every crit).

Oh, and Melerix thinks dual SAs are done, but many are still done wrong. Sigh...

Code: Select all

-(2599,'Raid Sword*Raid Sword','lrhand','true',2250,3,3,'fine_steel','c',190,10,'dual',8,0.00000,0,0,0,325,0,83,-1,-1,6130000,1885,'true','true','true','true',3045,2,0,0,0,0,0,0,0,'0-0;'),+(2599,'Raid Sword*Raid Sword','lrhand','true',2250,3,3,'fine_steel','c',190,10,'dual',8,0.00000,0,0,0,325,0,83,-1,-1,4713500,1885,'true','true','true','true',3045,8,0,0,0,0,0,0,0,'0-0;'), 

Edit: My diff file for weapon.sql is now at 5.6k lines. Good fun.

[MELERIX]

we know that

here could be some typos but no a big difference in the values, has you see at lvl 2 or lvl 8 is 1.04 anyway.

btw, tgs are you working in a new version of your SA rework ?

[toastgodsupreme]

we know that

here could be some typos but no a big difference in the values, has you see at lvl 2 or lvl 8 is 1.04 anyway.

btw, tgs are you working in a new version of your SA rework ?

Same version, just with massive updates.

Those ones I listed above are the last ones I need to finish, then I can start looking into masterwork bonuses.

Go find DrLecter for me. He's been a ghost lately and I need to send him my latest revision. It's already been committed and revised a number of times by me on another project (though I maintain compatibility with the core project).