Trade Scam.

[maxstyleboy]

How to block sending trade to character in combat or flag?

thanks!

[lion]

add check in TradeRequest

[Micr0]

add this in TradeRequest.java

Code: Select all

        if (!target.isPlayer())        {            player.sendPacket(SystemMessageId.INCORRECT_TARGET);            return;        }                +if(player.isInCombat())        +{        +   player.sendMessage("You cannot trade while you are in a combat state.");        +   return;        +} 

[Luna]

It only blocks when the target is in flag state, not when it is in combat.

[maxstyleboy]

Code: Select all

===================================================================--- TradeRequest.java@@ -138,6 +138,18 @@            return;        }        +       if (partner.isInCombat())+       {+           player.sendMessage("That person is in combat.");+           return;+       }+       +       if (player.isInCombat())+       {+           player.sendMessage("You cannot trade while in combat.");+           return;+       }+               if (BlockList.isBlocked(partner, player))        {            sm = SystemMessage.getSystemMessage(SystemMessageId.S1_HAS_ADDED_YOU_TO_IGNORE_LIST);

Thanks

[Konstantinos]

How to block sending trade to character in combat or flag?

thanks!

Do you have any problem with that?

[Luna]

Code: Select all

[javac]         if (partner.isInCombat())[javac]             ^[javac]   symbol:   variable partner[javac]   location: class TradeRequest[javac]  1 error

:s

[tukune]

if (player.isInCombat() || player.getPvpFlag() > 0)

[Luna]

It works, thanks tho

[maxstyleboy]

How to block sending trade to character in combat or flag?

thanks!

Do you have any problem with that?

Yes, players scam in siege!
If you request trade for any player, this player cannot use skills...

[Konstantinos]

How to block sending trade to character in combat or flag?

thanks!

Do you have any problem with that?

Yes, players scam in siege!
If you request trade for any player, this player cannot use skills...

thanks.

[Konstantinos]

Code: Select all

===================================================================--- TradeRequest.java@@ -138,6 +138,18 @@            return;        }        +       if (partner.isInCombat())+       {+           player.sendMessage("That person is in combat.");+           return;+       }+       +       if (player.isInCombat())+       {+           player.sendMessage("You cannot trade while in combat.");+           return;+       }+               if (BlockList.isBlocked(partner, player))        {            sm = SystemMessage.getSystemMessage(SystemMessageId.S1_HAS_ADDED_YOU_TO_IGNORE_LIST);

Thanks

ty i have to check that bug

[Pandragon]

Code: Select all

        if (partner.isInCombat() || (partner.getPvpFlag() > 0))        {            player.sendMessage("That person is in combat.");            return;        }                if (player.isInCombat() || (player.getPvpFlag() > 0))        {            player.sendMessage("You cannot trade while in combat.");            return;        }