[Question]How can i disable the Nevit's Blessing window?

[takhs7]

Hey guys,

So yeah.. i need to disable this since its useless in a high rate server and it only gets annoying having to close it every time you login.. (not to mention that its not implemented yet anyways.. is it?)

in a revision about a month ago (or so) it was not appearing if i remember correctly.. so im guessing it should be easy to disable it (hopefully).

(screenshot if u didnt get of what im talking about)


what file should i look at? i had no luck finding it in enterworld.java


edit:
sigh... never mind found it on enterworld.. sendPacket(new ExVoteSystemInfo(activeChar));
exvotesystem.. lol

[s5n4K3s]

Is safe to remove

sendPacket(new ExVoteSystemInfo(activeChar));

line?

[Heopas]

If you just remove that line, you will not be able to see it at char login. But you will see it *poping out* when someone rec you. Remove that line and search at RecoBonus to disable poping at rec too.

P.S. Sorry for bad english.

[hope]

all you had to do was to turn off the quest lol

[s5n4K3s]

all you had to do was to turn off the quest lol

Which quest? i try commenting

Code: Select all

 # Retail#~ retail/PriestOfBlessing/PriestOfBlessing.java 

in scripts.cfg, but without success

[JMD]

Tried all kinds of things, i managed to remove it on login but when someone recs you it still pops up, is there a way to remove it properly? Since its no finished i believe it should at least be disabled with configs.

[Pandragon]

Delete packet ExVoteSystemInfo.java
Delete all lines with errors after that.

[JMD]

Delete packet ExVoteSystemInfo.java
Delete all lines with errors after that.

I was hoping the solution not to be that extreme but i'll take it, thanks.

[JMD]

Here i made a patch for it.

https://gist.github.com/JMD13/5607722

[Szponiasty]

U could do that with 2 lines of code in L2PcInstance ;p

Code: Select all

     /**     * Send a Server->Client packet StatusUpdate to the L2PcInstance.<BR><BR>     */    @Override    public void sendPacket(L2GameServerPacket packet)    {        if (packet != null)        {            if (packet instanceof ExVoteSystemInfo)                return; 

[Okari]

Adding a test on every packet send is a very bad idea. An instanceof check even more so. It adds a lot of useless overhead.

Commenting out all occurences of ExVoteSystemInfo is the best solution imo.

[Zoey76]

Hehe, I think the fastest and cleaner solution would be to remove data written on client in ExVoteSystemInfo :

Code: Select all

- writeC(0xFE);- writeH(0xC9);- writeD(_recomLeft);- writeD(_recomHave);- writeD(_bonusTime);- writeD(_bonusVal);- writeD(_bonusType);

[Szponiasty]

Adding a test on every packet send is a very bad idea. An instanceof check even more so. It adds a lot of useless overhead.

Commenting out all occurences of ExVoteSystemInfo is the best solution imo.

Nah. It doesn't do any noticeable difference and I have long list of instance checks in packet broadcaster But I agree with Zoey - better solution

[UnAfraid]

I wouldn't even touch it.

[Okari]

I wouldn't even touch it.

Well, if you want to deactivate Nevit's Blessing and get rid of the window, you kinda have to.

It doesn't do any noticeable difference

While it is true that you might not notice it in that case, it is still important to avoid such things. Because developing software (especially servers) with that logic will lead to poor program performance.
Negligible impact + negligible impact + negligible impact + ... = noticeable impact.