Offline traders freya

[babyjason]

If you want to receive support we need this info to help you properly.
» Find Revision
L2J Revision Number:4417
L2JDP Revision Number: 7666

Hello, after server restart, when i shift+click on an offline shop, i get this error , and at char info it s written N/a. actually it did happen before, but never showed in error log or in gs as error as i recall in epilogue..

any ideea what it is and why? i mean is it a problem?

Code: Select all

Oct 12, 2010 7:33:43 AM handlers.admincommandhandlers.AdminEditChar gatherCharacterInfoWARNING: java.lang.StringIndexOutOfBoundsException: String index out of range: -9    at java.lang.String.substring(Unknown Source)    at handlers.admincommandhandlers.AdminEditChar.gatherCharacterInfo(AdminEditChar.java:823)    at handlers.admincommandhandlers.AdminEditChar.showCharacterInfo(AdminEditChar.java:809)    at handlers.admincommandhandlers.AdminEditChar.useAdminCommand(AdminEditChar.java:134)    at handlers.actionhandlers.L2PcInstanceActionShift.action(L2PcInstanceActionShift.java:49)    at com.l2jserver.gameserver.model.L2Object.onActionShift(L2Object.java:286)    at com.l2jserver.gameserver.network.clientpackets.Action.runImpl(Action.java:128)    at com.l2jserver.gameserver.network.clientpackets.L2GameClientPacket.run(L2GameClientPacket.java:62)    at com.l2jserver.gameserver.network.L2GameClient.run(L2GameClient.java:973)    at java.util.concurrent.ThreadPoolExecutor$Worker.runTask(Unknown Source)    at java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source)    at java.lang.Thread.run(Unknown Source)

[Zoey76]

Please check: viewtopic.php?f=69&t=19116

[babyjason]

ty! but could you explain, as in what this error means, if it s an error, or simply the game client doesent check the accounts name/ip of char... ty very much!

[hope]

Check this handlers.admincommandhandlers.AdminEditChar gatherCharacterInfo also check the htm file incase of a mistake in it that is giving you the error

[Zoey76]

It's not babyjason's version problem, I've checked on a clean version, the code is wrong.

When you shift-click a player (L2PcInstance) you retrieve information from the current client.
When the client is detached you get a null pointer exception at player.getClient().toString()
Anyway the problem in console appears when it tries to get a sub string with indexes indexOf("Account: ")+9 and indexOf(" - IP: ") on "[Character read failed due to disconnect]"

In my previous post it's the link to the solution, the version 1 is a simple fix adding a check when client is detached and removing unnecessary parsing and version 2 is a reworked version with last ip for offline shops.

[_DS_]

On next version address already cached in l2gameclient.