SkillCheckRemove Issue

Support for the latest build of L2J Server, get help here with installations, upgrades, problems.
Do not post bugs reports here, use viewforum.php?f=77 instead.
There is no support for other server builds than the official provided by l2jserver.com
Forum rules
READ NOW: L2j Forums Rules of Conduct
Starter
Posts: 484
Joined: Sat Jan 23, 2010 4:42 pm

SkillCheckRemove Issue

Post by Starter »

Is it only me or is the new feature (since Freya) removing the transferred skills which healer can achieve since eqilogue with holy pomander as well?

Im asking because im currently using the latest epi version with the needed code parts for the new feature and its removing the skills mentioned above too. :S
I have promises to keep and miles to go before I sleep.
User avatar
MELERIX
L2j Veteran
L2j Veteran
Posts: 6667
Joined: Sat Sep 23, 2006 11:31 pm
Location: Chile
Contact:

Re: SkillCheckRemove Issue

Post by MELERIX »

better use Freya, Epilogue is not supported now.
User avatar
JIV
L2j Veteran
L2j Veteran
Posts: 1882
Joined: Sun Jan 06, 2008 8:17 pm
Location: Slovakia
Contact:

Re: SkillCheckRemove Issue

Post by JIV »

disable skill remove.
_DS_
L2j Veteran
L2j Veteran
Posts: 3437
Joined: Wed Apr 30, 2008 8:53 am
Location: Russia

Re: SkillCheckRemove Issue

Post by _DS_ »

Worksforme. You fail to update tables properly. And not, you cant just take one little code fragment and use on different package, skill checker is quite complexive, in both core, datapack and data files.
Commiter of the shit
public static final int PI = 3.1415926535897932384626433832795;
Starter
Posts: 484
Joined: Sat Jan 23, 2010 4:42 pm

Re: SkillCheckRemove Issue

Post by Starter »

_DS_ wrote:Worksforme. You fail to update tables properly. And not, you cant just take one little code fragment and use on different package, skill checker is quite complexive, in both core, datapack and data files.
Yes I can. :mrgreen:

I think I didnt miss anyting core-side and datapack-side (skills and the one (?) modification of the skill transfer script) neither so I dont know where the problem could be. And data? Isnt datapack == data? :roll:

With tables you mean that you changed something in the database as well? I should take a closer look there then.^^
I have promises to keep and miles to go before I sleep.
_DS_
L2j Veteran
L2j Veteran
Posts: 3437
Joined: Wed Apr 30, 2008 8:53 am
Location: Russia

Re: SkillCheckRemove Issue

Post by _DS_ »

skill_trees
Commiter of the shit
public static final int PI = 3.1415926535897932384626433832795;
Starter
Posts: 484
Joined: Sat Jan 23, 2010 4:42 pm

Re: SkillCheckRemove Issue

Post by Starter »

_DS_ wrote:skill_trees
Thx! :D

Ah btw maybe I missed those skills but as said before im pretty sure that I didnt miss anything datapack-side so can you check if the aurabird skills and the master ability - defense skill are all excluded from the check as well (because they got removed from the players as well..)? (Cant check it myself atm from work because of the file view thingy and I cant download the whole source^^)
I have promises to keep and miles to go before I sleep.
_DS_
L2j Veteran
L2j Veteran
Posts: 3437
Joined: Wed Apr 30, 2008 8:53 am
Location: Russia

Re: SkillCheckRemove Issue

Post by _DS_ »

All subclass certification skills are excluded from main check.

Also, if applied non-properly, you possibly allow you players to learn forgotten scroll skills by specially crafted packet.
Commiter of the shit
public static final int PI = 3.1415926535897932384626433832795;
Starter
Posts: 484
Joined: Sat Jan 23, 2010 4:42 pm

Re: SkillCheckRemove Issue

Post by Starter »

Ok after checking the skill_trees table I see now that its better to just take the freya version - its way better then the epilogue version anyway - great work btw! :wink:
I have promises to keep and miles to go before I sleep.
Starter
Posts: 484
Joined: Sat Jan 23, 2010 4:42 pm

Re: SkillCheckRemove Issue

Post by Starter »

Okay the freya version is running fine but now there is the issue that skills learned through forgotten scrolls are removed somehow (at least I saw that curse of desparion got removed from a soultaker after logging in back again). Any idea?
I have promises to keep and miles to go before I sleep.
_DS_
L2j Veteran
L2j Veteran
Posts: 3437
Joined: Wed Apr 30, 2008 8:53 am
Location: Russia

Re: SkillCheckRemove Issue

Post by _DS_ »

This is easy: in default l2j datapack skill 1541 "Curse of Desparion" marked as not done.
If you make this skill by yourself - its your task to add it into skill_trees.

Anyway, i added it to the next release.
Commiter of the shit
public static final int PI = 3.1415926535897932384626433832795;
Starter
Posts: 484
Joined: Sat Jan 23, 2010 4:42 pm

Re: SkillCheckRemove Issue

Post by Starter »

_DS_ wrote:This is easy: in default l2j datapack skill 1541 "Curse of Desparion" marked as not done.
If you make this skill by yourself - its your task to add it into skill_trees.

Anyway, i added it to the next release.
Thank you! :)
I have promises to keep and miles to go before I sleep.
User avatar
MELERIX
L2j Veteran
L2j Veteran
Posts: 6667
Joined: Sat Sep 23, 2006 11:31 pm
Location: Chile
Contact:

Re: SkillCheckRemove Issue

Post by MELERIX »

Starter wrote:Okay the freya version is running fine but now there is the issue that skills learned through forgotten scrolls are removed somehow (at least I saw that curse of desparion got removed from a soultaker after logging in back again). Any idea?
is normal because that skill is not used in game yet (may be will be added to game in High Five or future L2 chornicles), same happens with skill Dual Blow, so don't use these skills plz.
Starter
Posts: 484
Joined: Sat Jan 23, 2010 4:42 pm

Re: SkillCheckRemove Issue

Post by Starter »

MELERIX wrote:
Starter wrote:Okay the freya version is running fine but now there is the issue that skills learned through forgotten scrolls are removed somehow (at least I saw that curse of desparion got removed from a soultaker after logging in back again). Any idea?
is normal because that skill is not used in game yet (may be will be added to game in High Five or future L2 chornicles), same happens with skill Dual Blow, so don't use these skills plz.
But isnt Dual Blow available in Freya already? I mean all other new skills are present except this one..?
I have promises to keep and miles to go before I sleep.
User avatar
jurchiks
Posts: 6769
Joined: Sat Sep 19, 2009 4:16 pm
Location: Eastern Europe

Re: SkillCheckRemove Issue

Post by jurchiks »

I had Elf Wind Rider on PTS and I don't remember having Dual Blow...
All forgotten scrolls were in pts helper shop (at least I think it was all of them)
If you have problems, FIRST TRY SOLVING THEM YOURSELF, and if you get errors, TRY TO ANALYZE THEM, and ONLY if you can't help it, THEN ask here.
Otherwise you will never learn anything if all you do is copy-paste!
Discussion breeds innovation.
Post Reply