Ticket #1285 (closed defect: fixed)

Opened 1 year ago

Last modified 3 months ago

with karma you can lose not dropable items

Reported by: kerb Assigned to:
Priority: critical Milestone:
Keywords: Cc:
DP Revision: 0 L2J Revision:
Geodata: Disabled

Description

dont know if this is bug, but when you have item type not dropable (for example nobles tiara) and you have karma and someone kill you, you can drop this item

Attachments

Change History

07/30/07 22:10:04 changed by MELERIX

The same happens with shadown weapons. not sure if this are normal or not, somebody that play on retail can confirm ?

07/31/07 11:20:57 changed by -Rnn-

pk cant drop not dropable items on retail, (augment, shadow, etc etc)

08/01/07 13:37:43 changed by anonymous

  • priority changed from minor to Normal.
/java/net/sf/l2j/gameserver/model/actor/instance/L2PcInstance.java
@@ -4404,7 +4404,8 @@
 					// Don't drop
 					if (
 							itemDrop.isAugmented() ||												// Dont drop augmented items
							itemDrop.getItemId() == 57 ||                                           // Adena
+							itemDrop.isDropable() ||
 							itemDrop.getItem().getType2() == L2Item.TYPE2_QUEST ||                  // Quest Items
 							nonDroppableList.contains(itemDrop.getItemId()) ||                      // Item listed in the non droppable item list
 							nonDroppableListPet.contains(itemDrop.getItemId()) ||                   // Item listed in the non droppable pet item list

no tested.

08/02/07 16:36:57 changed by Fulminus

There is also a list of protected items in one of the config files...I'm not sure if it's still used, but as an alternate temp fix you could try adding the shadow and noblesse items there, too...

07/15/08 19:37:44 changed by DrHouse

  • status changed from new to closed.
  • resolution set to fixed.

(In [2286]) Non droppable items shouldn't be dropped even when dying and karma > 0

Fixes #1285 (quite old), thanks "anonymous"

07/15/08 20:57:57 changed by anonymous

  • priority changed from Normal to critical.
  • status changed from closed to reopened.
  • resolution deleted.
  • revision changed from 1059 to 2286.

Think about it 30 secs.

If object is dropable it will return true... So if it return true to every object that is dropable, it will not drop when the player got karma.

By the way you can remove this line : 

itemDrop.isAugmented() ||												// Dont drop augmented items

it's checked in the "isDropable" function.

So please put a ! before itemDrop.isDropable()

Hope I'm not totally wrong and that it helped to avoid a big advantage for chaotic players ;)

07/15/08 21:03:16 changed by anonymous

Oups forget it, don't remove the isAugmented line *need sleep*

07/16/08 18:36:16 changed by nBd

  • status changed from reopened to closed.
  • resolution set to fixed.

http://www.l2jserver.com/trac/changeset/2287

Add/Change #1285 (with karma you can lose not dropable items)




Change Properties
Action