L2J Server

hello guys i wander somthing why in code doAttack we using 2 times

protected void doAttack(L2Character target)
{
if ((target == null) || isAttackingDisabled() || !getEvents().onAttack(target))
{
return;
}


because you using the same method on clientpacket AttackRequest.java

the null check in doAttack is for npcs or for players? or for l2phx?

Just simply...

lord_rex wrote:Just simply...

You are a badCat

Cobra wrote:

lord_rex wrote:Just simply...

You are a badCat

probably, but I am sure about that

3033 commits, Holy Cow!

Zoey76 wrote:3033 commits, Holy Cow!

ah, it's really old and a bit confused/mixed with deleted repositories, on open source I have just near 2,2-2,5K really, but on private repositories it would be near 4000...

Well well, look who the cat dragged in (pun intended). What's up? How you doing with your l2j project?

SpooKNoF wrote:hello guys i wander somthing why in code doAttack we using 2 times

protected void doAttack(L2Character target)
{
if ((target == null) || isAttackingDisabled() || !getEvents().onAttack(target))
{
return;
}


because you using the same method on clientpacket AttackRequest.java

the null check in doAttack is for npcs or for players? or for l2phx?

doAttack its called also by npcs AI's (those who attack), not only for players

jurchiks wrote:Well well, look who the cat dragged in (pun intended). What's up? How you doing with your l2j project?

thanks, fine, actually I work in private

And how's that working out for you?

jurchiks wrote:And how's that working out for you?

actually, we're working in the shadows

...so then how is it going? Good/bad? Any profit?

jurchiks wrote:...so then how is it going? Good/bad? Any profit?

we do not reached the stage of earning profit, need some months

BiggBoss wrote:

SpooKNoF wrote:hello guys i wander somthing why in code doAttack we using 2 times

protected void doAttack(L2Character target)
{
if ((target == null) || isAttackingDisabled() || !getEvents().onAttack(target))
{
return;
}


because you using the same method on clientpacket AttackRequest.java

the null check in doAttack is for npcs or for players? or for l2phx?

doAttack its called also by npcs AI's (those who attack), not only for players

yes i know that but i think null check is useless because doAttack use method HitTimer

inside method HitTimer you call again null check so...

public void onHitTimer(L2Character target, int damage, boolean crit, boolean miss, boolean soulshot, byte shld)
{
// If the attacker/target is dead or use fake death, notify the AI with EVT_CANCEL
// and send a Server->Client packet ActionFailed (if attacker is a L2PcInstance)
if ((target == null) || isAlikeDead() || (isNpc() && ((L2Npc) this).isEventMob()))
{
getAI().notifyEvent(CtrlEvent.EVT_CANCEL);
return;
}