Page 1 of 1

L2J changeset downloader

Posted: Wed Jan 12, 2011 12:08 pm
by jurchiks
Got inspiration and wrote a tiny, but handy, batch script to download changesets.
How to use: run it, choose to DL either core or datapack changesets, then input the changesets to diff.
Outputs core/datapack_%initial%-%target%.diff
The script automatically checks if you have Subversion installed and if it's not, it notifies you and stops the script.

Change 1: updated the SVN links.
Change 2: added Linux version; added check for Subversion client.
Change 3: fixed a small problem and a typo in the Windows script.

Re: L2J changeset downloader

Posted: Wed Jan 12, 2011 3:29 pm
by hope
nice tool but diff patch has nothing in it

Re: L2J changeset downloader

Posted: Wed Jan 12, 2011 3:36 pm
by jurchiks
Then you have put wrong changesets. It doesn't check if a changeset of selected number actually exists on the SVN.

Re: L2J changeset downloader

Posted: Sun Feb 06, 2011 8:51 pm
by feather56
Dude i have tryed everything but there is nothing in the .diff files.
Can you explain a bit more about this please? because this is really helpfull.
Thanks in advance!

Re: L2J changeset downloader

Posted: Sun Feb 06, 2011 8:57 pm
by Flashy
if you would have read the forum posts, u saw that the svn path was changed.
Simple change the svn roots in the scripts to:

http://svn.l2jserver.com/trunk/L2J_Server
http://svn.l2jdp.com/trunk/L2J_DataPack

Re: L2J changeset downloader

Posted: Sun Feb 06, 2011 9:26 pm
by feather56
Flashy wrote:if you would have read the forum posts, u saw that the svn path was changed.
Simple change the svn roots in the scripts to:

http://svn.l2jserver.com/trunk/L2J_Server
http://svn.l2jdp.com/trunk/L2J_DataPack
I have changed the links, but still the same problem.
Tryed different numbers, no one works, always nothing in the diff patch.
Or this should just create the .diff files with named changeset? :)

Re: L2J changeset downloader

Posted: Sun Feb 06, 2011 11:12 pm
by feather56
Any other way to get the .diff patch for every Changesets ?

Re: L2J changeset downloader

Posted: Mon Feb 07, 2011 11:25 am
by jurchiks
What exact steps are you doing? You should be doing it like this:
1) you run the program
2) you choose core/dp (for example 1 - core)
3) you input initial changeset (for example 4495)
4) you input target changeset (for example 4496)
That's it, you wait until it creates a file named "core_4495-4496.diff" in the same folder as the program.
As I already mentioned - DON'T input invalid/nonexistent changesets, there will be no output then.

Also, the tool already checks for it, but the target changeset must be higher than initial, not the same or lower. I don't think I should explain why.
feather56 wrote:Any other way to get the .diff patch for every Changesets ?
What do you mean by "every" changeset?

Re: L2J changeset downloader

Posted: Mon Feb 07, 2011 12:23 pm
by Flashy
He wrote me a pm..
it seems he forgot to install a svn client.
without it your tool isn' t working ofc.

Re: L2J changeset downloader

Posted: Mon Feb 07, 2011 12:30 pm
by BiggBoss
svn diff commands refer a command that calls the program to run setted in c:/documment and settings/your_user_name/application data/subverion/config @:

Code: Select all

 [helpers]diff-cmd= root to the subversion program 
if you have not the programn nor the var properly setted, it wont work.

Re: L2J changeset downloader

Posted: Mon Feb 07, 2011 1:29 pm
by jurchiks
Well, I had thought about that, but didn't think he would actually hope it to just work...
Not directly related to my tool though.

Re: L2J changeset downloader

Posted: Fri Feb 11, 2011 2:55 am
by burrito
Thx jurchiks for your tool, it is very helpful. Its good to see people share, even if it is a simple tool.

Re: L2J changeset downloader

Posted: Sat Feb 12, 2011 11:21 pm
by jurchiks
Updated first post, added Linux version of the same thing, a bit more advanced than Windows though (checks if changesets have numeric values to avoid creating empty files with letters instead of changesets), couldn't find the equivalent for Windows (yet) :/
If someone knows how to do it, let me know.
Also added check for Subversion presence (for reasons seen in the posts above) and automatic choosing of trunk folder name (since it changed recently).

Edit: there is only one known bug - if the initial changeset is before the trunk rename, and target - after, the diff will be empty. You have to make one diff before and one - after rename, can't do it any other way.

Re: L2J changeset downloader

Posted: Sun Feb 13, 2011 7:56 am
by Devastator
There are some problems with my Win7:
'else' is not recognized as an internal or external command, operable program or batch file.
Just need change a 53 and 54 lines from:

Code: Select all

)else if %choice==2 (
to:

Code: Select all

) else if %choice==2 (

Re: L2J changeset downloader

Posted: Sun Feb 13, 2011 10:36 am
by jurchiks
You can also remove the else since the variable `choice` can only have one value. I simply didn't want to check it twice, but if it's a problem I'll remove it, doesn't break the script.
Edit: there was also a typo, forgot the matching '%' symbol on the other side of the variable. First post updated.