[Bug] Anti-Feed Manager !

[PoRnosJH]

If you want to receive support we need this info to help you properly.
» Find Revision
L2J Revision Number: Last Freya
L2JDP Revision Number: Last Freya

Hello ..

I found a bug in my Server with Anti-Feed Manager so i downloaded a clean Core and made a Test server
100% L2J

But i found that the bug exists even there !... at the begin i thought i made something wrong in any code in my server..

So how is it goes :

If You have set in Options :

Code: Select all

# ---------------------------------------------------------------------------# AntiFeed# ---------------------------------------------------------------------------# This option will enable antifeed for pvp/pk/clanrep points.# Default: FalseAntiFeedEnable = True # If set to True, kills from dualbox will not increase pvp/pk points# and clan reputation will not be transferred.# Default: TrueAntiFeedDualbox = True # If set to True, server will count disconnected (unable to determine ip address)# as dualbox.# Default: TrueAntiFeedDisconnectedAsDualbox = False # If character died faster than timeout - pvp/pk points for killer will not increase# and clan reputation will not be transferred.# Setting to 0 will disable this feature.# Default: 120 seconds.[b]AntiFeedInterval = 0[/b]

Then you cant feed your self by making dual box bot and kill him ...

BUT if you have your setting like this :
(that is the best solution cause someone without this would be simply killing his friend's bot)

Code: Select all

# ---------------------------------------------------------------------------# AntiFeed# ---------------------------------------------------------------------------# This option will enable antifeed for pvp/pk/clanrep points.# Default: FalseAntiFeedEnable = True # If set to True, kills from dualbox will not increase pvp/pk points# and clan reputation will not be transferred.# Default: TrueAntiFeedDualbox = True # If set to True, server will count disconnected (unable to determine ip address)# as dualbox.# Default: TrueAntiFeedDisconnectedAsDualbox = False # If character died faster than timeout - pvp/pk points for killer will not increase# and clan reputation will not be transferred.# Setting to 0 will disable this feature.# Default: 120 seconds.[b]AntiFeedInterval = 120[/b]

Then someone can actually feed himself !!
How ?
1.Make a bot char .. dual-box ..
2.go and PvP with him (hit each other) without weap (simple hits) or low weap
3.after 2min kill him
4.Res
5.go and PvP with him (hit each other)
6.after 2min kill him
7. Vuala ! +1 PVP


If any Dev can find why this happens .. it must be something with the AntiFeedInterval ...
Any Help would be Welcomed

Thank you for your Time

[PoRnosJH]

Ok .. i worked some time in AntiFeedManager.java ...
and i have a Fix :

Code: Select all

Index: java/com/l2jserver/gameserver/instancemanager/AntiFeedManager.java===================================================================--- java/com/l2jserver/gameserver/instancemanager/AntiFeedManager.java  (revision 5374)+++ java/com/l2jserver/gameserver/instancemanager/AntiFeedManager.java  (working copy)@@ -75,9 +75,10 @@                if (Config.L2JMOD_ANTIFEED_INTERVAL > 0                && _lastDeathTimes.containsKey(targetPlayer.getObjectId()))-           return (System.currentTimeMillis() - _lastDeathTimes.get(targetPlayer.getObjectId())) > Config.L2JMOD_ANTIFEED_INTERVAL;-           -           if (Config.L2JMOD_ANTIFEED_DUALBOX && attacker != null)+           if ((System.currentTimeMillis() - _lastDeathTimes.get(targetPlayer.getObjectId())) < Config.L2JMOD_ANTIFEED_INTERVAL)+               return false;+       +       if (Config.L2JMOD_ANTIFEED_DUALBOX && attacker != null)            {                final L2PcInstance attackerPlayer = attacker.getActingPlayer();                if (attackerPlayer == null)@@ -85,6 +86,9 @@                                final L2GameClient targetClient = targetPlayer.getClient();                final L2GameClient attackerClient = attackerPlayer.getClient();+               if (targetClient == attackerClient)+                   return false;+                   if (targetClient == null                        || attackerClient == null                        || targetClient.isDetached() 

Maybe someone L2J.Dev can see my code and correct me ?
I want to put it on my Live server soon,,

thank you for your time