Offline shop major problem

This is not a Support area! Discuss about the Server here. Non-Server related discussion goes in Off-Topic Discussion.
Forum rules
READ NOW: L2j Forums Rules of Conduct
Attila
Posts: 441
Joined: Mon May 05, 2014 10:15 am

Re: Offline shop major problem

Post by Attila »

Avanael92 wrote:Well, tried to reproduce this problem.

I didn't realize, L2J uses develop branch now instead of master, so I have this problem too. In develop branch, this is fixed.

On master, this red line in OfflineTradersTable.java within the restoreOfflineTraders method is missing:
L2World.getInstance().addPlayerToWorld(player);
client.setState(GameClientState.IN_GAME);
player.setClient(client);
Without this line, the player is practically not ingame, so you can't kick him out of the game which results in this disconnect loop.

After adding this, I could login in two attempts after restart like explained here already.
Thanks so as to see the problem solved here :+1:
Sacrifice
Advanced User
Advanced User
Posts: 1026
Joined: Thu Aug 14, 2014 6:31 am

Re: Offline shop major problem

Post by Sacrifice »

Avanael92 wrote:Well, tried to reproduce this problem.

I didn't realize, L2J uses develop branch now instead of master, so I have this problem too. In develop branch, this is fixed.

On master, this red line in OfflineTradersTable.java within the restoreOfflineTraders method is missing:
L2World.getInstance().addPlayerToWorld(player);
client.setState(GameClientState.IN_GAME);
player.setClient(client);
Without this line, the player is practically not ingame, so you can't kick him out of the game which results in this disconnect loop.

After adding this, I could login in two attempts after restart like explained here already.
Good answer... I would not have done better... :+1: Good!
DevOps and Java Developer using Eclipse, Java 21, MySQL 8.0+
maxstyleboy
Posts: 183
Joined: Thu Jul 15, 2010 12:26 am

Re: Offline shop major problem

Post by maxstyleboy »

I have this problem on my server, not just trade offline. This can happen at any time. I do not understand why. :shifty: :shifty: :crazy:
gajet55
Posts: 20
Joined: Fri Jan 29, 2016 3:50 pm
Location: Moscow
Contact:

Re: Offline shop major problem

Post by gajet55 »

User avatar
CostyKiller
Posts: 220
Joined: Mon Aug 10, 2009 11:48 pm
Location: Romania

Re: Offline shop major problem

Post by CostyKiller »

I have this problem too, players can't login after server restarts if they had offline shops.

Note: If I disable offline shop restore, problem is gone.
User avatar
Avanael92
Advanced User
Advanced User
Posts: 189
Joined: Thu Aug 07, 2014 5:26 pm
Location: Germany

Re: Offline shop major problem

Post by Avanael92 »

Do you even read? :problem:
User avatar
CostyKiller
Posts: 220
Joined: Mon Aug 10, 2009 11:48 pm
Location: Romania

Re: Offline shop major problem

Post by CostyKiller »

Yes I read your post, but I have that red line there already, and still happens. :)
Post Reply