We moved our repositories to BitBucket!

If you can't login or you can't register to the forums do not rise an issue, instead please write to support (at) l2jserver.com

Check our wiki!

Report server issues here

Forum has been updated to phpBB 3.2, let's see if this fixes some minor bugs we had.

Thank you for visiting http://www.l2jserver.com/

L2J Changes

Read me first before posting anywhere!
Forum rules
READ NOW: L2j Forums Rules of Conduct

What do you want for L2J? (Pick two)

Poll ended at Sun May 11, 2014 10:45 pm

Bugs and exploit fixes!!!
36
38%
New missing features!
30
32%
Customs!!
6
6%
My contributions committed...
2
2%
Compatibility with new game versions.
20
21%
 
Total votes: 94

User avatar
jurchiks
Posts: 6760
Joined: Sat Sep 19, 2009 4:16 pm
Location: Eastern Europe

Re: L2J Changes

Post by jurchiks » Sun May 04, 2014 2:50 pm

@Zoey - c3p0 is outdated and there are much better and cleaner solutions out there.
@UnAfraid - I wouldn't be so sure about that. The added complexity wouldn't be worth it IMHO. I know you like complexity for some reason, but not everybody does.
If you have problems, FIRST TRY SOLVING THEM YOURSELF, and if you get errors, TRY TO ANALYZE THEM, and ONLY if you can't help it, THEN ask here.
Otherwise you will never learn anything if all you do is copy-paste!
Discussion breeds innovation.

xban1x
L2j Veteran
L2j Veteran
Posts: 1228
Joined: Thu Jan 17, 2013 9:46 am

Re: L2J Changes

Post by xban1x » Sun May 04, 2014 3:54 pm

jurchiks wrote:@Zoey - c3p0 is outdated and there are much better and cleaner solutions out there.
@UnAfraid - I wouldn't be so sure about that. The added complexity wouldn't be worth it IMHO. I know you like complexity for some reason, but not everybody does.
Okari showed an implementation for JPA and Hibernate. It resulted in massive amounts of classes...

User avatar
jurchiks
Posts: 6760
Joined: Sat Sep 19, 2009 4:16 pm
Location: Eastern Europe

Re: L2J Changes

Post by jurchiks » Sun May 04, 2014 4:09 pm

That's what I meant.
If you have problems, FIRST TRY SOLVING THEM YOURSELF, and if you get errors, TRY TO ANALYZE THEM, and ONLY if you can't help it, THEN ask here.
Otherwise you will never learn anything if all you do is copy-paste!
Discussion breeds innovation.

User avatar
UnAfraid
L2j Veteran
L2j Veteran
Posts: 4195
Joined: Mon Jul 23, 2007 4:25 pm
Location: Bulgaria
Contact:

Re: L2J Changes

Post by UnAfraid » Sun May 04, 2014 4:22 pm

jurchiks wrote:That's what I meant.
When i mention hibernate i didn't had this example in mind at all.
Image

User avatar
jurchiks
Posts: 6760
Joined: Sat Sep 19, 2009 4:16 pm
Location: Eastern Europe

Re: L2J Changes

Post by jurchiks » Sun May 04, 2014 4:36 pm

Nevertheless, changing the dbcp doesn't require rewriting everything to do with the database.
If you have problems, FIRST TRY SOLVING THEM YOURSELF, and if you get errors, TRY TO ANALYZE THEM, and ONLY if you can't help it, THEN ask here.
Otherwise you will never learn anything if all you do is copy-paste!
Discussion breeds innovation.

User avatar
UnAfraid
L2j Veteran
L2j Veteran
Posts: 4195
Joined: Mon Jul 23, 2007 4:25 pm
Location: Bulgaria
Contact:

Re: L2J Changes

Post by UnAfraid » Sun May 04, 2014 5:05 pm

jurchiks wrote:Nevertheless, changing the dbcp doesn't require rewriting everything to do with the database.
What's the point of changing it just like that when there will be no difference?
Image

User avatar
jurchiks
Posts: 6760
Joined: Sat Sep 19, 2009 4:16 pm
Location: Eastern Europe

Re: L2J Changes

Post by jurchiks » Sun May 04, 2014 5:23 pm

There will be a difference in performance.
If you have problems, FIRST TRY SOLVING THEM YOURSELF, and if you get errors, TRY TO ANALYZE THEM, and ONLY if you can't help it, THEN ask here.
Otherwise you will never learn anything if all you do is copy-paste!
Discussion breeds innovation.

User avatar
UnAfraid
L2j Veteran
L2j Veteran
Posts: 4195
Joined: Mon Jul 23, 2007 4:25 pm
Location: Bulgaria
Contact:

Re: L2J Changes

Post by UnAfraid » Sun May 04, 2014 6:17 pm

jurchiks wrote:There will be a difference in performance.
Do you have performance issues with c3p0?
Weird i had over 3k players with c3p0 and i didn't had issues.
Neither nBd he had 9k (almost) with c3p0 and it was working pretty good are there nowdays such servers?
Image

User avatar
jurchiks
Posts: 6760
Joined: Sat Sep 19, 2009 4:16 pm
Location: Eastern Europe

Re: L2J Changes

Post by jurchiks » Sun May 04, 2014 6:20 pm

So you're of those types who believe in "good enough"? Even if it can be much better?
If you have problems, FIRST TRY SOLVING THEM YOURSELF, and if you get errors, TRY TO ANALYZE THEM, and ONLY if you can't help it, THEN ask here.
Otherwise you will never learn anything if all you do is copy-paste!
Discussion breeds innovation.

User avatar
UnAfraid
L2j Veteran
L2j Veteran
Posts: 4195
Joined: Mon Jul 23, 2007 4:25 pm
Location: Bulgaria
Contact:

Re: L2J Changes

Post by UnAfraid » Sun May 04, 2014 6:21 pm

jurchiks wrote:So you're of those types who believe in "good enough"? Even if it can be much better?
I am saying that this changes pointless either we change the whole approach to make it really better or we simply don't even touch it.
Image

User avatar
jurchiks
Posts: 6760
Joined: Sat Sep 19, 2009 4:16 pm
Location: Eastern Europe

Re: L2J Changes

Post by jurchiks » Sun May 04, 2014 6:24 pm

Yeah, and doing it step by step is not even an option, right?
If you have problems, FIRST TRY SOLVING THEM YOURSELF, and if you get errors, TRY TO ANALYZE THEM, and ONLY if you can't help it, THEN ask here.
Otherwise you will never learn anything if all you do is copy-paste!
Discussion breeds innovation.

User avatar
UnAfraid
L2j Veteran
L2j Veteran
Posts: 4195
Joined: Mon Jul 23, 2007 4:25 pm
Location: Bulgaria
Contact:

Re: L2J Changes

Post by UnAfraid » Sun May 04, 2014 6:26 pm

jurchiks wrote:Yeah, and doing it step by step is not even an option, right?
If we switch to hibernate step by step is out of the picture
Image

User avatar
Zoey76
L2j Inner Circle
L2j Inner Circle
Posts: 6861
Joined: Tue Aug 11, 2009 3:36 am

Re: L2J Changes

Post by Zoey76 » Sun May 04, 2014 6:41 pm

Do you know you could be writing code instead of writing posts? :mrgreen:
Using Eclipse Photon 4.8 - OpenJDK11 - MySQL 8.0.12 - L2J Server :+1:
Live support

User avatar
jurchiks
Posts: 6760
Joined: Sat Sep 19, 2009 4:16 pm
Location: Eastern Europe

Re: L2J Changes

Post by jurchiks » Sun May 04, 2014 6:43 pm

@Zoey - You don't want me to answer to that.

@UnAfraid - Why do you think hibernate is the only/best option?
If you have problems, FIRST TRY SOLVING THEM YOURSELF, and if you get errors, TRY TO ANALYZE THEM, and ONLY if you can't help it, THEN ask here.
Otherwise you will never learn anything if all you do is copy-paste!
Discussion breeds innovation.

User avatar
UnAfraid
L2j Veteran
L2j Veteran
Posts: 4195
Joined: Mon Jul 23, 2007 4:25 pm
Location: Bulgaria
Contact:

Re: L2J Changes

Post by UnAfraid » Sun May 04, 2014 7:05 pm

jurchiks wrote:@UnAfraid - Why do you think hibernate is the only/best option?
I am not sure which one is going to be yet.
hibernate is nice but could be something else for example http://javalite.io/activejdbc
Image

Locked